Cvs Commit: cvsnt

CVSROOT:	/usr/local/cvs
Module name:	cvsnt
Changes by:	[email protected]		Wed Nov  7 19:01:57 2007
On host:	mail.march-hare.com

Directory: cvsnt

M build.h		1.62 -> 1.63	Bug Id: 

Directory: cvsnt/cvsapi/win32

M DirectoryAccess.cpp		1.16 -> 1.17	Bug Id: 

Directory: cvsnt/cvsio

M CvsEntry.cpp		1.23 -> 1.24	Bug Id: 
M RecurseRepository.cpp		1.19 -> 1.20	Bug Id: 

Directory: cvsnt/evsfs

M VirtualFs.cpp		1.37 -> 1.38	Bug Id: 

Directory: cvsnt/src

M checkin.cpp		1.46 -> 1.47	Bug Id: 
M classify.cpp		1.50 -> 1.51	Bug Id: 
M client.cpp		1.180 -> 1.181	Bug Id: 
M commit.cpp		1.134 -> 1.135	Bug Id: 
M CompatRecursion.cpp		1.71 -> 1.72	Bug Id: 
M import.cpp		1.101 -> 1.102	Bug Id: 
M no_diff.cpp		1.30 -> 1.31	Bug Id: 
M server.cpp		1.214 -> 1.215	Bug Id: 
M update.cpp		1.147 -> 1.148	Bug Id: 

Log message:
When you commit in a directory and a sub-directory has the change then
this causes catastrophic client failures becaus the server returns
a rubbish filename, eg:

chceked in file Binary/fish.gif
Server returns /evscmm/remote/installer/Binary/Binary/fish.gif


Calls to server_update_entries() and server_checked_in()
use inconsistent variables for parameter 1:

classify.cpp uses file->sandbox.filename.c_str()
no_diff.cpp uses CFileAccess::filename_of(file->sandbox.filename.c_str())
update.cpp uses file->display_filename.c_str() (for both calls)
checkin.cpp uses file->display_filename.c_str()
add.cpp uses file->display_filename.c_str()
commit.cpp uses file->display_filename.c_str()
remove.cpp uses file->sandbox.filename.c_str()


Through trial and error it appears as though  in checkin the correct one
to use is "sandbox" so I suspect all the references to 'display' are 
simply incorrect.


This change mostly just adds a whole lot of debugging, but also does
fix the call in checkin.cpp.  NOtable this doesn't "fix" add since I
haven't verified that the 'problem' occurs with add yet.