Issue 175 - Usher hates Monotone saying anything other than "beginning service" (contrib)

Hello,

A new issue has been created and assigned
to you:

175 - Usher hates Monotone saying anything other than "beginning service"
Project: tools and contributions
Status: New
Reported by: Judson Lester
Labels:
 Type:Defect
 Priority:Medium

Description:

Steps to reproduce the problem:
1. Add a print statement to your rcfile "print('hello out there')
2. Start usher such that that rcfile will load
3. Attempt to sync with usher

Expected result:

Ideally: usher forks monotone and sync begins.

Less ideally: usher reports somewhere, anywhere that the output "hello out there" is not the expected "beginning service"

Actual result:

"Received warning from usher: Cannot fork server."

This is caused by server::fork checking only the first line for 'beginning service' based on the commented assumption that otherwise monotone's stderr is reporting that it failed to launch.

A side effect of this is that adding -v to the monotone args will also silently crash Usher.

--
Issue: https://code.monotone.ca/p/contrib/issues/175/