Re: issue 201; missing certs are easily generated, but reported as a serious problem

Stephen Leake <[email protected]>
Newsgroups gmane.comp.version-control.monotone.devel
Message-ID <[email protected]>
Stephen Leake <[email protected]> writes:

> One fix is very simple; in database_check.cc, take missing_certs out of
> the 'serious' sum. Then 'db check' reports:
>
> mtn: revision 114f6aa58c7707bf83516d4080ca6268c36640ad missing branch cert
> mtn: warning: 1 missing certs
> mtn: check complete: 2 files; 2 rosters; 2 revisions; 1 keys; 7 certs; 3 heights; 1 branches
> mtn: total problems detected: 1 (0 serious)
> mtn: minor problems detected
>
>
> On the other hand, perhaps some certs are more important than others? We
> could count branch certs separately from author and date, and then just
> leave missing_branch_certs out of the 'serious' sum.

Another fix, as the problem report suggests, is to change the netsync
code to pull all certs for a revision; only use the branch filter to
decide which revision to pull.

-- 
-- Stephe
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.