Re: Updated Issue 212 - sync needs list of include patterns (monotone)
Stephen Leake <[email protected]>
| Newsgroups | gmane.comp.version-control.monotone.devel |
|---|---|
| Message-ID | <[email protected]> |
Stephen Leake <[email protected]> writes: > [email protected] writes: > >> Hello, >> >> The following issue has been updated: >> >> 212 - sync needs list of include patterns >> Project: monotone >> Status: New >> Reported by: Stephen Leake >> URL: https://code.monotone.ca/p/monotone/issues/212/ >> Labels: >> Type:Feature Request >> Priority:Medium >> >> Comments (last first): >> >> # By Stephen Leake, Aug 25, 2012: >> >> The pre-1.0 sync syntax allowed multiple include patterns (multiple >> GLOBs) and multiple exclude patterns (--exclude options). The 1.0 URI >> syntax only allows one include pattern. >> > > It turns out this is not true; the code supports multiple include > patterns, but the user manual says (in the URI syntax) that it does not. > > I added a unit test in monotone/test/unit/tests/uri.cc that demonstrates > this: > > test_one_uri("mtn://venge.net/monotone?include1;-exclude1;-exclude2;include2", > "mtn", "", "venge.net", "", "/monotone", "{include1,include2}", "{exclude1,exclude2}"); > > In the user manual, the URI syntax is described as: > > <scheme>://[[<user>@@]<host>[:<port>]][/<path>][?<pattern>[;-<exclude-pattern>[...]]] > > That says there is only one include pattern, but multiple exclude > patterns. The examples only show one include and one exclude. > > I suggest we change it to this: > > <scheme>://[[<user>@@]<host>[:<port>]][/<path>][?<include-pattern>[;<include-or-exclude-pattern>]...] Actually, the first pattern can also be an exclude. So a simpler syntax is this: <scheme>://[[<user>@@]<host>[:<port>]][/<path>][?<pattern>[;<pattern>]...] Branches matching a pattern are excluded if the pattern starts with '-', included otherwise. -- -- Stephe