Re: boost 1.53 breaks monotone build

Markus Wanner <[email protected]>
Newsgroups gmane.comp.version-control.monotone.devel
Message-ID <[email protected]>
Richard,

On 03/14/2013 07:58 PM, Richard Hopkins wrote:
> It also seems there a patch to fix it, but how (if we need to)
> should we keep compatibility with older boost?

To me, it looks like dynamic_pointer_cast is old enough to be usable for
us. At least according to their documentation, it is included since 1.34:

http://www.boost.org/doc/libs/1_34_0/libs/smart_ptr/pointer_cast.html

The oldest installed boost I had lying around was 1.46. And monotone
compiled just fine there. Having all instance of shared_dynamic_cast
replaced with dynamic_pointer_cast. And I can confirm it works with
boost 1.53, so I committed this change in dfe4b51c...

If somebody has an ancient boost ready to test against, please try that
revision. We can still add a check against BOOST_VERSION.

Regards

Markus Wanner
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.