Re: nvm C++11

On 05/18/2014 08:18 PM, Stephen Leake wrote:
> Markus Wanner <[email protected]> writes:
> 
>> We can put such things in src/base.hh or add to CXXFLAGS via the
>> configure script. 
> 
> I added to src/base.hh:

I did that, already. And the Cygwin build animal confirms it works (it
shows a strange failure on one functional test, though). Please pull
from monotone.ca.

> Now I have another one:

I see no issue. Just a reasonable warning.  :-)

> g++  -I. -I../monotone    -I/usr/include/botan-1.10          -g -O2 -Wall -Wextra -Wno-unused -Wno-unused-parameter -std=c++11 -MT src/netxx/datagram.o -MD -MP -MF $depbase.Tpo -c -o src/netxx/datagram.o ../monotone/src/netxx/datagram.cxx &&\
> mv -f $depbase.Tpo $depbase.Po
> ../monotone/src/netxx/datagram.cxx: In constructor ‘Netxx::Datagram::Datagram(const char*, Netxx::port_type, const Netxx::Timeout&)’:
> ../monotone/src/netxx/datagram.cxx:100:29: warning: ‘auto_ptr’ is deprecated (declared at /usr/lib/gcc/x86_64-pc-cygwin/4.8.2/include/c++/backward/auto_ptr.h:87) [-Wdeprecated-declarations]
>      std::auto_ptr<pimpl> ap(pimpl_ = new pimpl(timeout));
> 
> Apparently unique_ptr is supposed to replace auto_ptr. That is done in
> mandatory-cxx11. So I guess we should just suppress this warning in nvm?

Feel free. Mind you: Older versions of gcc might not know the flag, so
introducing it might actually already raise the barrier... (And I see
use for that warning for nvm.mandatory-cxx11.)

Regards

Markus Wanner

_______________________________________________
Monotone-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/monotone-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iEYEAREDAAYFAlN5AtsACgkQsPwMloDjyo/FSACfbpOY/Yw2y9se91A2zwLGKrNg
p88AnA03GxINMdlQSE7UmUwh92ybT94+
=+ftq
-----END PGP SIGNATURE-----