Re: Official snapshot with Botan 2

On 2021-07-21 01:18, Lapo Luchini wrote:
> If a bit of testing effort can be put together I think we better create 
> a proper new release with those patches included, as when I fixed botan2 
> patch in April I just didn't have enough time to ensure it was working 
> for everyone (I only checked it was working "enough for me").

As a starter on that, I executed the test scripts.

This testing on WSL/Ubuntu, I will also try FreeBSD later today:

% mtn hea
mtn: branch 'net.venge.monotone.lapo.botan2' is currently merged:
95111069650467d834f109f505545124ac6846a9 [email protected] 06/04/2021 08:50:31
% ./run_unit_tests
Of 142 tests run:
         142 succeeded
% ./run_tester_tests
Of 6 tests run:
         6 succeeded
./run_extra_tests
Of 8 tests run:
         5 succeeded
         1 had expected failures
         2 were skipped
% ./run_func_tests
Of 616 tests run:
         535 succeeded
         41 failed
         37 had expected failures
         3 were skipped

I'm not sure if those 41 failures are actual regressions (and I can't 
build/test the current "trunk" release on this setup) but I'll leave 
them here:

Specifically these:
   2 (imp)_persistent_netsync_server_-_keys_2      FAIL (line 17)
  68 automate_generate_key                         FAIL (line 6)
  90 automate_key_manage                           FAIL (line 12)
  91 automate_keys                                 FAIL (line 12)
115 bad_and_unknown_certs                         FAIL (line 11)
123 branch_leaves_sync_bug                        FAIL (line 40)
134 changing_passphrase_of_a_private_key          FAIL (line 7)
169 creating_a_bad_criss-cross_merge              FAIL (line 43)
176 database_dump_load                            FAIL (line 6)
182 db_data_format_checking                       FAIL (line 25)
184 db_fix_certs                                  FAIL (line 12)
194 db_rosterify_on_a_db_with_a_root_suture       FAIL (line 8)
195 db_rosterify_preserves_renames                FAIL (line 6)
196 db_rosterify_twice_gives_an_error_second_time FAIL (line 8)
229 do_not_log_the_result_of_hook_get_passphrase  FAIL (line 10)
230 drop_a_public_and_private_key                 FAIL (line 4)
263 generating_and_extracting_keys_and_certs      FAIL (line 13)
298 key_files_created_securely                    FAIL (line 18)
300 key_management_without_a_database             FAIL (line 5)
377 mtn_read_FILE                                 FAIL (line 6)
386 netsync_client_absorbs_server_key             FAIL (line 9)
390 netsync_duplicate_keys                        FAIL (line 8)
393 netsync_hook_errcodes                         FAIL (line 57)
395 netsync_key_hooks                             FAIL (line 14)
401 netsync_permissions                           FAIL (line 14)
407 netsync_verifies_server_keys                  FAIL (line 6)
417 persistent_netsync_server_-_keys              FAIL (line 10)
435 read_and_convert_old_privkey_packet           FAIL (line 8)
504 rosterify_--drop-attr                         FAIL (line 20)
505 rosterify_handles_.mt-ignore_files            FAIL (line 13)
506 rosterify_migrates_file_dir_attrs             FAIL (line 27)
507 rosterify_on_a_db_with_1_rev                  FAIL (line 11)
508 rosterify_on_a_db_with_an_empty_manifest      FAIL (line 11)
510 schema_migration                              FAIL (line 99)
512 schema_migration_error_recovery               FAIL (line 17)
514 schema_migration_with_rosterify               FAIL (line 93)
535 ssh_agent                                     FAIL (line 27)
541 status_with_no_key                            FAIL (line 22)
546 sync_use_ws_opts                              FAIL (line 25)
558 test_the_approve_command                      FAIL (line 7)
562 trust_hooks_and_trusted_command               FAIL (line 22)

-- 
Lapo Luchini
http://lapo.it/