Re: simple valgrind test found what appear to be serious memory problems
Thien-Thi Nguyen <[email protected]> Tue, 05 Oct 2010 00:14:51 +0200
| Newsgroups | gmane.comp.version-control.rcs.bugs |
|---|---|
| Message-ID | <[email protected]> |
() Paul Eggert <[email protected]> () Thu, 30 Sep 2010 09:21:35 -0700 by a careful code audit. I have changed my practice a (tiny) bit. The non-initializing allocation function ‘alloc’ (b-divvy.c) now includes a warning. :-) More seriously, i have reviewed the complete fanout of ‘alloc’ and found/fixed bugs where structures (using the allocation) are not fully initialized, as well as other memory-related bugs. The (abridged) list of changes in the repo since 5.7.93 is now: $ glog 5.7.93.. --reverse [...] f1383af [maint] Do "gnulib-tool --add-import" for bootstrap. dc2ff9d [maint] Simplify ‘PATHPREFIX’ Makefile-internal protocol. db5a008 [int] Use ‘struct symdef’ array as "three manifestations" ‘merge’ arg. 140ab2d [maint] Let the configure script instantiate rcsfreeze. c269dd3 [v] Use Automake for test preparation. b4ae77b [int] Avoid identifier ‘SHARED’ (Solaris 8 header conflict). 44060ab [int] Fix bug: Save notyet objects in caller space. 7489411 [build] Delete unused macro. a231f5c [int] Fix bug: Fully initialize notyet objects. 154cc2b [int] Fix bug: Fully initialize delta objects. df3b780 [v] Use Automake for building xorlf. c6dfec5 [v] Do stdout/stderr split in shell func, not in makefile. f607093 [v] Make test wd in common; arrange for cleanup there, too. fcd6d46 [v] Use Automake for generating top-level test driver. fed95b9 [int] Fix bug: Initialize notyet ‘.branches’ correctly. f6d4053 [v] Delete unused shell func. f3de5d2 [v] Centralize shell vars ‘w’, ‘v’. At the moment, i am overhauling tests/, trying to decide whether or not to test against libparts.a (via src/yarrrr.c repurposing). WDYT?