Re: RCS-5.8.2 Re: rcs-5.7.96 build feedback

Thien-Thi Nguyen <[email protected]> Sun, 03 Aug 2014 23:58:04 +0200

Newsgroups	gmane.comp.version-control.rcs.bugs
Message-ID	<[email protected]>

() Thien-Thi Nguyen <[email protected]>
() Sun, 03 Aug 2014 18:05:01 +0200

   DTRT for RCS for this release

As i don't have GCC 3.4.3 (or Solaris 10) around to play with,
i attach here for public review the wip patch that adds a
configure-time test and arranges to ‘#define ARSZ_FN_PARM_OK’:


If there are no objections, i will install it shortly, along
w/ the changes to the .c files to use ‘ARSZ_FN_PARM_OK’.

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

configure.diff (text/x-diff, 880 B)

 configure.ac | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/configure.ac b/configure.ac
index 248479f..b4fc775 100644
--- a/configure.ac
+++ b/configure.ac
@@ -280,6 +280,23 @@ AS_IF([RCS_YESP([use_mmap])],[AC_CHECK_HEADERS([sys/mman.h])])
 # types -- see also: (info "(autoconf) Particular Types")
 AC_TYPE_UID_T

+# checks for compiler characteristics
+
+AC_CACHE_CHECK([if compiler handles dependent array-size in func param],
+[rcs_cv_dep_arsz_func_parm],[
+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]],[[
+/* GCC 3.4.3 on Solaris 10 cannot handle this.  */
+int
+last (int count, int all[count])
+{
+  return all[count - 1];
+}
+]])],[res=yes],[res=no])
+  rcs_cv_dep_arsz_func_parm=$res
+])
+RCS_CBOOL([ARSZ_FN_PARM_OK],[yes],[rcs_cv_dep_arsz_func_parm=$res],
+  [Can the compiler handle dependent array-size in a func param?])
+
 # funcs

 AC_FUNC_FORK

signature.asc (application/pgp-signature, 197 B)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlPesG8ACgkQZwMiJEyAdQKUswCeIYivca2GrkplE3sH24LF9Ejy
V94AoKKDHipHS+mRNZsJPLUdfX8vFB5M
=Q5It
-----END PGP SIGNATURE-----