Re: rcs-5.9.4: make check: tests 510 511 603 604 605 900 999 failed on AIX

Thien-Thi Nguyen <[email protected]> Tue, 27 Jan 2015 10:17:18 +0100

Newsgroups	gmane.comp.version-control.rcs.bugs
Message-ID	<[email protected]>

() Michael Felt <[email protected]>
() Mon, 26 Jan 2015 19:49:00 +0100

   I have always 'remembered' RCS as a directory where the
   comma-v files were stored, so I was not surprised to see RCS
   as a directory.

Normally, "RCS" is a directory containing comma-v files.  RCS
should be able to operate just fine with the comma-v in the same
directory as the working file, however.  For most of the tests,
"x" is the working file and "x,v" is the comma-v file (all in
the same tNNN.d directory).

I'm beginning to think that specifying ‘--disable-threads’ is
not the right approach, and that propagating the makefile var
‘LIBTHREAD’ as determined by the configure script, is.  Perhaps
something in gnulib is not so flexible and was not fully tested
w/ threads disabled under AIX.  So, i've just installed:

 http://git.savannah.gnu.org/cgit/rcs.git/commit/?h=p&id=cdc017067
 http://git.savannah.gnu.org/cgit/rcs.git/commit/?h=p&id=6dd5ca388

which do that for "make" and "make check" flows, respectively.
Could you please apply these patches to the freshly-unpacked
Makefile.in files in src/ and tests/, respectively:


then configure (*without* ‘--disable-threads’) and "make" and
"make check VERBOSE=1"?

   What puzzles me though is that the same errors are reported -
   but/and there are err files in test-dirs that passed.

   root@x064:[/data/test/rcs-5.9.4]make VERBOSE=1 check
   [...]

That's not a problem.  For most tests, the test infrastructure
splits stdout/stderr unconditionally (in tests/common, see shell
func ‘split_std_out_err’).

   On Mon, Jan 26, 2015 at 3:13 PM, Thien-Thi Nguyen <[email protected]> wrote:
   [...]

Could you please omit this bottom-citing in future posts?
We prefer to avoid top-posting on GNU mailing lists, generally.
TIA for your cooperation on this.

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

Makefile.in.diff (text/x-diff, 1.3 KB)

--- Makefile.in.ORIG	2015-01-26 12:42:06.000000000 +0100
+++ Makefile.in	2015-01-27 09:29:42.000000000 +0100
@@ -214,17 +214,18 @@
 ident_SOURCES = ident.c
 ident_OBJECTS = ident.$(OBJEXT)
 ident_LDADD = $(LDADD)
-ident_DEPENDENCIES = libparts.a
+am__DEPENDENCIES_1 =
+ident_DEPENDENCIES = libparts.a $(am__DEPENDENCIES_1)
 merge_SOURCES = merge.c
 merge_OBJECTS = merge.$(OBJEXT)
 merge_LDADD = $(LDADD)
-merge_DEPENDENCIES = libparts.a
+merge_DEPENDENCIES = libparts.a $(am__DEPENDENCIES_1)
 am__objects_1 = ci.$(OBJEXT) co.$(OBJEXT) rcsclean.$(OBJEXT) \
 	rcsdiff.$(OBJEXT) rcsmerge.$(OBJEXT) rlog.$(OBJEXT)
 am_rcs_OBJECTS = rcs.$(OBJEXT) $(am__objects_1) super.$(OBJEXT)
 rcs_OBJECTS = $(am_rcs_OBJECTS)
 rcs_LDADD = $(LDADD)
-rcs_DEPENDENCIES = libparts.a
+rcs_DEPENDENCIES = libparts.a $(am__DEPENDENCIES_1)
 am__vpath_adj_setup = srcdirstrip=`echo "$(srcdir)" | sed 's|.|.|g'`;
 am__vpath_adj = case $$p in \
     $(srcdir)/*) f=`echo "$$p" | sed "s|^$$srcdirstrip/||"`;; \
@@ -1375,7 +1376,7 @@
 executables = ident merge rcs
 BUILT_SOURCES = $(subs:=.help) $(executables:=.help) super.help
 rcs_SOURCES = rcs.c $(subs:=.c) super.c
-LDADD = libparts.a -L$(top_builddir)/lib -lgnu
+LDADD = libparts.a -L$(top_builddir)/lib -lgnu $(LIBTHREAD)
 CLEANFILES = $(BUILT_SOURCES) $(subs)
 EXTRA_DIST = sub.TEMPLATE
 all: $(BUILT_SOURCES)

Makefile.in.diff (text/x-diff, 859 B)

--- Makefile.in.ORIG	2015-01-27 10:04:35.000000000 +0100
+++ Makefile.in	2015-01-27 09:41:35.000000000 +0100
@@ -191,7 +191,9 @@
 CONFIG_CLEAN_VPATH_FILES =
 btdt_SOURCES = btdt.c
 btdt_OBJECTS = btdt.$(OBJEXT)
-btdt_DEPENDENCIES = ../src/libparts.a ../lib/libgnu.a
+am__DEPENDENCIES_1 =
+btdt_DEPENDENCIES = ../src/libparts.a ../lib/libgnu.a \
+	$(am__DEPENDENCIES_1)
 AM_V_P = $(am__v_P_@AM_V@)
 am__v_P_ = $(am__v_P_@AM_DEFAULT_V@)
 am__v_P_0 = false
@@ -1318,7 +1320,7 @@
 # If we use ‘btdt_CPPFLAGS’ here instead of ‘AM_CPPFLAGS’,
 # Automake creates btdt-btdt.o instead of simply btdt.o.
 AM_CPPFLAGS = -I$(top_srcdir)/src -I$(top_srcdir)/lib
-btdt_LDADD = ../src/libparts.a ../lib/libgnu.a
+btdt_LDADD = ../src/libparts.a ../lib/libgnu.a $(LIBTHREAD)
 
 # This helps certain RCS programs find their peers.
 PATHPREFIX = $(abs_top_builddir)/src

signature.asc (application/pgp-signature, 197 B)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlTHV6IACgkQZwMiJEyAdQJCNACgsxDUHyaFuhBG1ascIavMFJRc
SVAAoNDtE2UnPdofVCoRbRz6FF4PY6TP
=FBYJ
-----END PGP SIGNATURE-----