Re: Failed tests with macOS Sequoia 15.5

Mark Prior <[email protected]> Tue, 3 Jun 2025 07:08:31 +0930
Newsgroups gmane.comp.version-control.rcs.bugs
Message-ID <[email protected]>
On 3/6/2025 04:13, Paul Eggert wrote:
> On 2025-06-02 05:03, Mark Prior wrote:
>> Hi, I just built RCS 5.10.1 on my MacBook and it failed a number of 
>> tests.
> 
> What version of macOS are you using? What compiler? What are the 
> symptoms if you don't install the patch?
> 
> I can't reproduce the problem on my macOS platform, which looks like this:
> 
> $ gcc --version
> Apple clang version 14.0.0 (clang-1400.0.29.202)
> Target: arm64-apple-darwin21.6.0
> Thread model: posix
> InstalledDir: /Library/Developer/CommandLineTools/usr/bin
> $ sw_vers
> ProductName:    macOS
> ProductVersion:    12.6
> BuildVersion:    21G115
> 
> 
> I built RCS 5.10.1 with './configure; make; make check'. All checks 
> passed, and I didn't need to make any patches.

Hi Paul,

As it says in the subject I am using macOS 15.5 (the most recent release).

% gcc --version
Apple clang version 17.0.0 (clang-1700.0.13.5)
Target: arm64-apple-darwin24.5.0
Thread model: posix
InstalledDir: 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
% sw_vers
ProductName:		macOS
ProductVersion:		15.5
BuildVersion:		24F74

I would suggest that you need to upgrade as I had previously been using 
5.9.4 but sometime since I last used it and now some version of macOS 
had broken it as it now just "Abort" when I try to check in a file so 
after trying rebulding 5.9.4 and it failing I checked for a newer 
version and downloaded 5.10.1 and configure'd it. That was fine but make 
had issues, including

strerror.c:59:7: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
    59 |       sprintf (buf, fmt, n);
       |       ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
1 warning generated.

vasnprintf.c:3437:35: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  3437 |                                   sprintf ((char *) p, "%+d", 
exponent);
       |                                   ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:3445:35: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  3445 |                                   sprintf (expbuf, "%+d", 
exponent);
       |                                   ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:3588:35: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  3588 |                                   sprintf ((char *) p, "%+d", 
exponent);
       |                                   ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:3596:35: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  3596 |                                   sprintf (expbuf, "%+d", 
exponent);
       |                                   ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:4048:37: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  4048 |                                     sprintf ((char *) p, 
"%+.2d", exponent);
       |                                     ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:4056:37: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  4056 |                                     sprintf (expbuf, "%+.2d", 
exponent);
       |                                     ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:4229:45: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  4229 |                                             sprintf ((char *) 
p, "%+.2d", exponent);
       |                                             ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:4237:45: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  4237 |                                             sprintf (expbuf, 
"%+.2d", exponent);
       |                                             ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:4521:39: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  4521 |                                       sprintf ((char *) p, 
decimal_format, exponent);
       |                                       ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:4529:39: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  4529 |                                       sprintf (expbuf, 
decimal_format, exponent);
       |                                       ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:4714:47: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  4714 |                                               sprintf ((char *) 
p, decimal_format, exponent);
       |                                               ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
vasnprintf.c:4722:47: warning: 'sprintf' is deprecated: This function is 
provided for compatibility reasons only.  Due to security concerns 
inherent in the design of sprintf(3), it is highly recommended that you 
use snprintf(3) instead. [-Wdeprecated-declarations]
  4722 |                                               sprintf (expbuf, 
decimal_format, exponent);
       |                                               ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:278:1: 
note: 'sprintf' has been explicitly marked deprecated here
   278 | __deprecated_msg("This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of 
sprintf(3), it is highly recommended that you use snprintf(3) instead.")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
12 warnings generated.

These I ignored but

b-divvy.c:43:32: error: incompatible function pointer types assigning to 
'void (*)(void) __attribute__((noreturn))' from 'void (void)' 
[-Wincompatible-function-pointer-types]
    43 |   obstack_alloc_failed_handler = xalloc_die;
       |                                ^ ~~~~~~~~~~
1 error generated.

was the reason for the search for the patch. After applying that more 
warnings ensued.

rcsrev.c:239:33: warning: adding 'int' to a string does not append to 
the string [-Wstring-plus-int]
   239 |         author ? " and author " + (date ? 0 : 4) : "",
       |                  ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
./b-complain.h:64:56: note: expanded from macro 'RERR'
    64 | #define RERR(...)      generic_error (REPO (filename), __VA_ARGS__)
       |                                                        ^~~~~~~~~~~
rcsrev.c:239:33: note: use array indexing to silence this warning
   239 |         author ? " and author " + (date ? 0 : 4) : "",
       |                                 ^
       |                  &              [
./b-complain.h:64:56: note: expanded from macro 'RERR'
    64 | #define RERR(...)      generic_error (REPO (filename), __VA_ARGS__)
       |                                                        ^
rcsrev.c:241:31: warning: adding 'int' to a string does not append to 
the string [-Wstring-plus-int]
   241 |         state ? " and state " + (date || author ? 0 : 4) : "",
       |                 ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
./b-complain.h:64:56: note: expanded from macro 'RERR'
    64 | #define RERR(...)      generic_error (REPO (filename), __VA_ARGS__)
       |                                                        ^~~~~~~~~~~
rcsrev.c:241:31: note: use array indexing to silence this warning
   241 |         state ? " and state " + (date || author ? 0 : 4) : "",
       |                               ^
       |                 &             [
./b-complain.h:64:56: note: expanded from macro 'RERR'
    64 | #define RERR(...)      generic_error (REPO (filename), __VA_ARGS__)
       |                                                        ^
2 warnings generated.

rcstime.c:103:15: warning: adding 'int' to a string does not append to 
the string [-Wstring-plus-int]
   102 |              ("19%.*s/%.2s/%.2s %.2s:%.2s:%s"
       |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   103 |               + (date[2] == '.' && VERSION (5) <= BE (version) 
? 0 : 2)),
       | 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
rcstime.c:103:15: note: use array indexing to silence this warning
   102 |              ("19%.*s/%.2s/%.2s %.2s:%.2s:%s"
       |
       |               &
   103 |               + (date[2] == '.' && VERSION (5) <= BE (version) 
? 0 : 2)),
       |               ^ 

       |               [ 
        ]
1 warning generated.

rcsutil.c:347:17: warning: 'vfork' is deprecated: Use posix_spawn or 
fork [-Wdeprecated-declarations]
   347 |     if (!(pid = vfork ()))
       |                 ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/unistd.h:608:1: 
note: 'vfork' has been explicitly marked deprecated here
   608 | __deprecated_msg("Use posix_spawn or fork")
       | ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:218:48: 
note: expanded from macro '__deprecated_msg'
   218 |         #define __deprecated_msg(_msg) 
__attribute__((__deprecated__(_msg)))
       |                                                       ^
1 warning generated.

rlog.c:190:24: warning: adding 'bool' to a string does not append to the 
string [-Wstring-plus-int]
   190 |     aprintf (out, pre5 + "\tlocked by: %s;", node->lockedby);
       |                   ~~~~~^~~~~~~~~~~~~~~~~~~~
rlog.c:190:24: note: use array indexing to silence this warning
rlog.c:906:32: warning: adding 'int' to a string does not append to the 
string [-Wstring-plus-int]
   906 |           aputs ("  ;  strict" + (locks ? 3 : 0), out);
       |                  ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
rlog.c:906:32: note: use array indexing to silence this warning
   906 |           aputs ("  ;  strict" + (locks ? 3 : 0), out);
       |                                ^
       |                  &             [                ]
2 warnings generated.