Re: Expected revision inaccurate with Filter::map

On Sun, Sep 05, 2004 at 02:17:39PM +0100, Chia-liang Kao wrote:
> It seems Filter::map doesn't relect the <<delete>> revisions, so the
> dest driver can finish with the progress bar not finished.

Fix tested in test suite and applied; care to test in in vivo?

> Overriding rev_count() doesn't look appropriate as ::map itself
> doesn't know how many revisions will be deleted at that time.  Maybe
> it should call pr_doing when deleted, but it obstructuring the
> layering, and doesn't reflect the real revisions to be written either.

Good analysis.

> Suggestions?

There's a "skip_rev()" that should be called by any filters that need to
discard revs and don't aggregate revs.  Aggregating filters that discard
revs can either call skip_rev() or doctor the rev_count().

- Barrie