Re: Turning cvs2{svn,git} into cvs2hg

Greg Ward wrote:
> On Tue, Aug 4, 2009 at 3:32 PM, Michael Haggerty<[email protected]> wrote:
>> I see that you have made lots of other changes in your Mercurial repo
>> before and after the 5 that you referred to above.
> 
> Oh boy have I ever.  The really cool thing about DVCS is that it
> allows random strangers to go completely bonkers improving each
> other's code.  The flipside, of course, is that it allows random
> strangers to go completely bonkers improving each other's code.

I am happy to have you go bonkers.  I only humbly suggest that we try to
stay in close contact (modulo vacations!) to ensure that your changes
fit smoothly into cvs2svn and can be merged back into the mainline.

>> Please let me know
>> specifically which other patches you would like me to consider for
>> cvs2svn trunk.
> 
> Um... err... all of them!  However, please don't waste your time
> picking through that repository.  I'm a compulsive committer, and lots
> of mistakes and false starts are recorded there.  My plan is to start
> sending you reasonably sized patches once cvs2hg starts settling down
> into something usable: e.g. anything that cvs2svn can convert can also
> be handled by cvs2hg, and I can use it on a real-world CVS repository
> at work.  It's getting there; hopefully later this week.

Sounds good.

> If you do feel like getting a feel for what's coming, you should
> probably just clone my hg repo (if you haven't already done so):
> http://vc.gerg.ca/hg/cvs2svn/ .  The changes that are most likely to
> pique your interest (as in, they might break existing undertested
> functionality) are the extraction of large chunks of
> git_output_option.py to a new module dvcs_common.py.  The patch
> relative to current svn might be a bit big at the moment, and I can
> break it up into 2 or 3 more manageable patches if you like.  But for
> now, you can just peek at my tip occasionally for a sneak preview.

I glanced at your repo through the web interface but won't spend much
time on it until you tell me that parts are "ripe".

Actually, I do all of my cvs2svn development using git-svn, and I
occasionally push one or two active branches to

    http://repo.or.cz/w/cvs2svn.git

I would suggest that as a place for collaboration, but alas, the curse
of the multiple DVCSs has struck again, unless you would consider using
git or some git-hg adapter...

> BTW, what's the preferred way to send patches?

My main preference is that the patches be bite-sized pieces, one
indivisible change per patch as far as possible.  It would also be great
if you would include suggested commit log messages formatted as
described in the Subversion hacking guide [1], though I'm not as picky
as the Subversion project.

The URLs that you sent with the last patches were actually rather
convenient; the log messages were easy to copy-paste and it was easy to
apply the patches to my working copy with commands like

    wget -O - http://vc.gerg.ca/hg/cvs2svn/raw-rev/e79fb91e68e6 \
        | patch -p1

(of course I had to use the URL of the "raw" diff).

Michael

[1] http://subversion.tigris.org/hacking.html#patches

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2380170

To unsubscribe from this discussion, e-mail: [[email protected]].