Re: Changing topo sort behaviour

On Thu, Aug 6, 2009 at 1:08 PM, Michael Haggerty<[email protected]> wrote:
> You will note that there are several topological
> sorts; the first involves only RevisionChangesets, then only
> SymbolChangesets, then all Changesets.
[...]
> The question is, how to change this?  I don't think you want to skip the
> chronological ordering altogether, because it helps the heuristic that
> decides which SymbolChangesets to break up to break cycles in the
> dependency graph.

...ahhh, so that means I should ignore RevisionTopologicalSortPass and
focus on TopologicalSortPass.  Thanks; I probably would have figured
that out eventually, but I'm sure you've just saved me many hours of b
banging my head on the wrong sort.

Oh, a related question: is there a straightforward way to figure out
the head of a branch?  It would be nice if
HgOutputOption.process_branch_commit() knew that it was processing the
last revision on the current branch.  I think I could cobble something
together in the hg-specific topo sort, but if that information is
already available elsewhere, there's no point in duplicating it.

> This hasn't been needed yet, but it would be easy.  The "passes" array
> at the bottom of passes.py would be defined by the individual main()
> variants based on what they need.

That's about what I figured.  The hard part will be a
Mercurial-specific TopologicalSortPass; I'll see if I can get that
working with a hack before refactoring the passes list.  That will be
a snap by comparison.

Thanks!

Greg

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2380968

To unsubscribe from this discussion, e-mail: [[email protected]].