Re: Weird scoping issue in options file

Greg Ward wrote:
> On Thu, Aug 20, 2009 at 6:52 PM, Michael Haggerty<[email protected]> wrote:
>> I have committed your suggested patch (as trunk r4879), since it seems
>> like the right thing to do (even aside from the fact that it actually
>> works).
> 
> Cool.  Is there any way to write a test for that?  It would be nice to
> catch if someone in 3 years breaks the execfile() call.  The fact that
> you couldn't repro my problem with a cvs2svn options file is
> troubling.

No, I didn't try to reproduce your problem in the full context of
cvs2svn.  I was trying to write a baby test case similar to the ones in
the attachment to my last email, and at that I didn't succeed (though
without trying very hard).  When I could produce similar errors, I had
something to play with and my curiosity was satisfied :-), especially
since you had already submitted a working patch.

> [...details omitted...]
> Is that enough info to create a proper test case?

I highly doubt that anybody would muck around with the call to
execfile(), but if you are worried about it then I think it would be
adequate to just add a comment to the code in that area rather than
having an extra test case to run each time.

Michael

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2386295

To unsubscribe from this discussion, e-mail: [[email protected]].