Re: [PATCHES]: factor dvcs_common.py out of git_run_options.py, git_output_option.py

On Mon, Aug 24, 2009 at 5:13 PM, Michael Haggerty<[email protected]> wrote:
> Greg Ward wrote:
>> Oops, I forgot to normalize the URLs to use 'tip' rather than the
>> latest changeset ID.  Here is what I meant to send:
>>
>> 1) Factor module dvcs_common.py out of git_output_option.py.
>>     http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/create-dvcs-common.patch
>> 2) git_run_options: reduce differences with svn_run_options.
>>     http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/git-run-like-svn.patch
>> 3) Factor DVCSRunOptions out of GitRunOptions.
>>     http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/dvcs-run-options.patch
>> 4) Move code for analyzing fixup commits to DVCSOutputOption.
>>     http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/move-fixup-analysis.patch
>> 5) Factor MirrorUpdater out of GitRevisionWriter and move it to dvcs_common.py
>>     http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/mirror-updater.patch
>
> Maybe I goofed, but when I apply these patches, test 145 from the test
> suite fails (see results below).

No, I screwed up a merge.  Fixed.  And this time, I ran all the
git-related tests after each patch, and the full test suite after the
last patch.  Should be good this time:

    http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/create-dvcs-common.patch
    http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/git-run-like-svn.patch
    http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/dvcs-run-options.patch
    http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/move-fixup-analysis.patch
    http://vc.gerg.ca/hg/cvs2svn-patches/file/tip/mirror-updater.patch

>  Also, please apply the attached patch
> on top of your first patch.

Done.

Greg

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2386885

To unsubscribe from this discussion, e-mail: [[email protected]].