Re: Refactoring common RunOptions code

Greg Ward wrote:
> I was just about to send my next patch, which adds hg_run_options.py.
> But then I remembered that it's got a bunch of code copied straight
> from svn_run_options.py: blecch.  [...]
> 
> Two questions:
> 
> 1) should I just submit hg_run_options.py as-is and refactor later? or
> do you want the refactoring done first?

Of course it would be nice if the refactoring were done first, but I
wouldn't reject the patches for that reason.  I guess the question is
whether you gain anything by submitting-then-refactoring.  If so, then
it's OK.

> 2) how to refactor? it looks like the obvious thing to do is move the
> common code up to RunOptions.  This will be trivial for HgRunOptions,
> since I deliberately did not change the copied methods.  But
> GitRunOptions might need a bit more work to re-unify.

Sounds reasonable.  Any cleaning up that you do on GitRunOptions would
be appreciated but of course you are not obligated to do it yourself.

BTW, how is the test framework coming along?  I would be a little bit
nervous about committing changes to code that used to work without
having at least some simple tests that you haven't broken anything.  So
it would be preferable to work on the tests before the refactoring
rather than vice versa.

Michael

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2387790

To unsubscribe from this discussion, e-mail: [[email protected]].