Re: Proposal: Land Greg Ward's patchset immediately

On Fri, Oct 16, 2009 at 5:13 AM, Max Bowsher <[email protected]> wrote:
> Given that Greg's patches focus almost exclusively on adding new code, I
> feel happy that it won't break anything existing even without having
> been able to properly review it.
>
> Given that the current cvs2git/bzr output option is, whilst usable, not
> 100% correct or polished, I don't feel its right to hold the hg code to
> a higher standard before admitting it to the repository.
>
> On that basis, my inclination is to land Greg's pending patchset
> (witholding README.cvs2hg because it is written assuming that it is
> located in a fork) immediately, and pursue more in depth review after it
> is on trunk.

Sounds good to me!  (Naturally.)

BUT:

  * the 15 or so patches I posted here a few weeks ago are only half
the story; there are another ~15 patches yet to come (you can see them
all in my public MQ repository, but they are not polished and tested
like the first batch)

  * I have made more changes on the trunk of my public hg repo that
are a little more experimental and possibly half-baked (e.g. sloppy
fixup mode, timezone support).  Also git and bzr conversion deserve
similar treatment, and I have focussed exclusively on hg support.

Thus, I do NOT recommend that you grab the latest state of my public
repo.  Instead, you should pester me mercilessly until I cough up the
complete series of 30 or so patches, polished to shining perfection
and ruthlessly tested.  Then commit 'em all.  (I have not put time
into this because I've been waiting for someone to ask for more.
Polishing patches is a lot of work.)

*Then* we can talk about my beyond-basic-hg-support patches.

Greg

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2408350

To unsubscribe from this discussion, e-mail: [[email protected]].