Re: svn commit: r4951 - trunk/cvs2svn_lib/passes.py

Max Bowsher <[email protected]> Tue, 10 Nov 2009 00:41:46 +0000
Newsgroups gmane.comp.version-control.subversion.cvs2svn.devel
Message-ID <[email protected]>
Michael Haggerty wrote:
> Max Bowsher wrote:
>> Author: maxb
>> Date: 2009-11-07 07:57:08-0800
>> New Revision: 4951
>>
>> Modified:
>>    trunk/cvs2svn_lib/passes.py
>>
>> Log:
>> Stash the PersistenceManager in the Ctx during OutputPass. I have need of
>> random access to revisions from the GitOutputOption.
>>
>> [...]
>> +    Ctx().persistence_manager = PersistenceManager(DB_OPEN_READ)
> 
> Context.clean() deletes members whose names start with a single "_" and
> retains the others from pass to pass.  So I think this member name
> should be prefixed with an underscore (even though OutputPass is the
> last pass so it will probably make no practical difference).

Thanks for the catch, I'm sadly rusty on the wider view of the codebase.

Fixing...

Max.

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2415966

To unsubscribe from this discussion, e-mail: [[email protected]].
signature.asc (application/pgp-signature, 197 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkr4ttIACgkQfFNSmcDyxYCbjwCcCF38h1Br1kWkHfkR0tesRQ0M
EyYAn3TffR3RP3nZPh8t61Gim5VQVQxy
=Ibru
-----END PGP SIGNATURE-----