Re: [PATCH] Default-exclude symbol strategy
Michael Haggerty <[email protected]> Fri, 05 Mar 2010 10:42:15 +0100
| Newsgroups | gmane.comp.version-control.subversion.cvs2svn.devel |
|---|---|
| Message-ID | <[email protected]> |
Thanks for all of the patches! I've had limited computer time lately because of back problems, so I apologize for delays in responding to you. Jon Foster wrote: > When migrating a large CVS repository, there are many branches to > consider migrating. One option is to say "we'll migrate everything > except [some list of branches]". Cvs2svn has good support for that, > with "--exclude" and it's options-file equivalents. But I want to do > something a bit different - by default I want to exclude everything, > and only include what's specifically asked for. This makes a lot of sense. I noticed that the code for ExcludeRemainingStrategyRule is almost identical to that for AllBranchRule and AllTagRule, and indeed it has a similar purpose. What do you think we derive these three classes from a common base class like _CatchAllRule(action), where action is one of the constructors Branch, Tag, or ExcludedSymbol (similar to what is done for _RegexpStrategyRule and the derived classes ForceBranchRegexpStrategyRule, ForceTagRegexpStrategyRule, and ExcludeRegexpStrategyRule)? It would also be logical (and trivial) to allow this option to be selected via "--symbol-default=exclude". Let me know if you like this idea and would like to work on a new version of the patch (that would be great!). If not, I will commit your patch as-is and home some day to get around to making the suggested change myself. > ********************************************************************** > This email and its attachments may be confidential and are intended > solely for the use of the individual to whom it is addressed. Any > views or opinions expressed are solely those of the author and do not > necessarily represent those of Cabot Communications Ltd. > > If you are not the intended recipient of this email and its > attachments, you must take no action based upon them, nor must you > copy or show them to anyone. > > Cabot Communications Limited Verona House, Filwood Road, Bristol BS16 > 3RY, UK +44 (0) 1179584232 > > Co. Registered in England number 02817269 > > Please contact the sender if you believe you have received this email > in error. > > ********************************************************************** Your emails have this frightening warning appended to them. Just to be really clear about things, would you please confirm once explicitly that you are submitting the patches for inclusion in the open-source cvs2svn project under its existing license? Thanks, Michael ------------------------------------------------------ http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2455352 To unsubscribe from this discussion, e-mail: [[email protected]].