Re: [PATCH] New SymbolTransforms

Hi,

Jon Foster wrote:
> Here are three new SymbolTransforms I've written.  I hope these are
> generic and useful enough to be accepted into cvs2svn.
>
> * SubtreeSymbolTransform

This one is already committed.

> * IgnoreTagsExceptSpecifiedOnesSymbolTransform
> * ExcludeBranchesSymbolTransform

I'm not sure what you want me to do with these last two SymbolTransforms.

It seems to me that the same functionality can be implemented via
SymbolStrategyRules, which are generally more powerful and less fidgety.
 Is there a reason to implement them as SymbolTransforms?

> P.S. It looks like SymbolTransforms have to be defined in the
> cvs2svn core - I originally tried to define these in my options.py
> file, but that fails with a pickle error.

Oh, yes, that's awkward.  The reason is that the options file is
execfile()ed rather than imported, so the Pickle module has no way to
know how to access the class definitions when it is trying to unpickle
the SymbolTransform instances.

However, it should be possible to define the classes in any Python file
that can be imported when new passes are starting.  In other words, the
definitions needn't be in the cvs2svn core.

It would be nice if this were easier.  But off the top of my head I
can't think of a way.

Michael

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2465998

To unsubscribe from this discussion, e-mail: [[email protected]].