Re: Is _get_source_groups() return value really sorted?

On Sun, Aug 22, 2010 at 11:45 PM, Michael Haggerty <[email protected]> wrote:
> You changed the docstring of _get_source_groups() to claim that the
> return value is ordered by svn_revnum, but I don't see any reason why it
> should be so.  Is that just a blooper?
>
> I am referring to this commit:
>
> http://repo.or.cz/w/cvs2svn.git/commit/2100ae10c567083c0d7b5b06d2629b044c58a505
>
> which comes from your
>
> http://vc.gerg.ca/hg/cvs2svn/rev/3c5b3ad06427

I remember doing that refactoring, but I don't remember why I changed
the doc from "arbitrary order" to "sorted on revnum".  Very likely it
is a blooper.  Especially since I took special care to rearrange the
tuples so they *could* be sorted by revnum if the caller wants to!
Maybe I meant to throw in the sort() call and forgot to?

Greg

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2664573

To unsubscribe from this discussion, e-mail: [[email protected]].