Re: Handling of warnings from cvs (cvs checkout: Skipping `$Log$' keyword due to excessive comment leader)

On 11/15/2010 07:19 PM, Jonathan Nieder wrote:
> Side notes:
> 
> It crashes unless I redirect output to a seekable file.

Hmmm, yes.  I wonder whether it would be worth the extra work to enable
it to work with a non-seekable output?  I'd assumed that git-fast-import
is so vastly faster than the intervening cvs2git steps that the
parallelism wouldn't gain much in wall-clock time.  (Of course it would
save having to write the blobs to a big temporary file.)

> I can avoid that by redirecting output to a seekable file, but then
> fast-import crashes.

It sounds like this implies that the --use-external-blob-generator
option plus git-fast-import is broken no matter how you use it, but
below you propose removing its "experimental" designation.  So I must be
misunderstanding something.  Is the problem that the blob and dump data
are interleaved?  If so, then it shouldn't be too hard to have cvs2git
wait until the external blob generator is finished before starting to
generate dumpfile info.

> -- 8< --
> Subject: cvs2git: clarify documentation of --use-external-blob-generator

Thanks for the patch.  Committed as r5304 (followed by some related
changes).

>  There is a "git fast-import" patch in flight that would allow
>  removing that second requirement by asking fast-import for a
>  reminder about blobs past.
> 
>  The last discussed iteration of that patch is
>  http://thread.gmane.org/gmane.comp.version-control.git/159117/focus=159116
> 
>  and there is there is also a cleaned-up version available:
>  http://repo.or.cz/w/git/jrn.git/shortlog/refs/topics/db/fast-import-cat-blob?hp=593ce2bea
> 
>  Thoughts welcome.

I've been half-following that patch on the git mailing list but haven't
yet seriously thought about using the new feature due to lack of time
plus the rationalization listed above :-)

Michael

-- 
Michael Haggerty
[email protected]
http://softwareswirl.blogspot.com/

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=2682112

To unsubscribe from this discussion, e-mail: [[email protected]].