Re: cvs2svn bug - regex can match partial symbol

On 12/17/2012 09:51 PM, O'Brien, Jason K wrote:
> I'd submit this to the issue tracker, but it says to email here
> first, so here I go:
> 
> Seems that the _RegexpStrategyRule class tacks '^' and '$' around a
> regex to match full lines only, which doesn't work when the regex
> contains a top level OR ("|") due to order of operations.
> 
> For example, "foo|bar" becomes "^foo|bar$", which matches "foobaz"
> and "bazbar". This causes some confusion, as branches I explicitly
> excluded were blocking other branches from being excluded (apparently
> matching a ForceBranch rule overrides an exclusion rule). I figure
> putting a non-capturing group around it should do the trick.

You are quite right.  Thanks for the fix!  I just committed it as trunk
r5409.

Michael

-- 
Michael Haggerty
[email protected]
http://softwareswirl.blogspot.com/

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=3036740

To unsubscribe from this discussion, e-mail: [[email protected]].