Re: [Issue 149] too many open files using PyPy

Michael Haggerty <[email protected]> Fri, 14 Jun 2013 09:07:09 +0200
Newsgroups gmane.comp.version-control.subversion.cvs2svn.devel
Message-ID <[email protected]>
On 05/18/2013 08:23 AM, Michael Haggerty wrote:
> On 05/17/2013 08:27 PM, Jan Smets wrote:
>> Pass 16 (output pass) is running out of memory after several hours.
>> Probably some PyPy effect too. Any idea if there is anything in that
>> pass that isn't properly freeing memory?
>> I'll see what I can find, but my python knowledge is weak/non-existing.
>>
>> Thanks for all your great help!
> 
> The CPython garbage-collector is only needed for circular reference
> loops, because most unused objects are cleared via reference counting.
> cvs2svn is careful not to create any reference loops, so the
> garbage-collector was costing a lot of overhead but bringing zero
> benefit.  So:
> 
> * In main.py:main(), we turn off the CPython garbage-collector by
> calling gc.disable().
> [...]

I just pushed revisions r5430 and r5431, which make cvs2svn turn off the
garbage collector only if it is sure that it is running under CPython.

Michael

-- 
Michael Haggerty
[email protected]
http://softwareswirl.blogspot.com/

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=3058050

To unsubscribe from this discussion, e-mail: [[email protected]].