Re: Exclusion of files in Attic during git conversion not working.

On 08/05/2013 05:44 PM, Etan Reisner wrote:
> I can't seem to exclude files in Attic paths when doing a cvs2git
> conversion. I've tried using paths to the files both with and without
> Attic in them (though I am fairly certain that the /Attic/ version
> should be the right paths to use).
> 
> I ended up adding a bunch of logging statements to
> _RepositoryWalker.generate_cvs_paths and assuming I've understood my
> output correctly it looks like _generate_attic_cvs_files just doesn't
> process excludes.
> 
> Was this just missed when the exclusion support was originally added
> or is converting these files necessary for some reason I don't
> understand yet?

This looks like a simple oversight.  Thanks for reporting it.

I just pushed a commit to the GitHub version of the repo that should fix
the problem:

    https://github.com/mhagger/cvs2svn/tree/exclude-attic-paths

For the exclude_paths values, you need to use the names of files
relative to the CVS root directory, including the "Attic" parts.

Please test it and let me know if it works.  If so, I will apply the
change to trunk/master.  If you are feeling extra ambitious, consider
writing some tests for our test suite to test exclude_paths, which
AFAICT is completely untested at present.

Michael

-- 
Michael Haggerty
[email protected]
http://softwareswirl.blogspot.com/

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=3062127

To unsubscribe from this discussion, e-mail: [[email protected]].