Re: cvs2git: wrong commit grouping

On 07/01/2014 09:17 AM, Matwey V. Kornilov wrote:
> I am running cvs2git 2.4.0. Attached here is a shrunk test-case. The
> issue is the following, when using cvs2git in the output dump.dat file
> I have two commits:
> 
> [...]
> 
> I am pretty sure, based on the original CVS timestamps of the files,
> that they must be:
> 
> [...]

Good catch!  Due to a longstanding coding error,
InitializeChangesetsPass was trying to split such groups of commits at
the *shortest* timestamp gap, not the *longest* one as it should have
done.  (Though this comparison was only used as a tiebreaker when the
two gaps broke the same number of internal dependencies within the
proto-changeset.)  I just fixed this and pushed the fix to master.

Thanks,
Michael

-- 
Michael Haggerty
[email protected]

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=3084297

To unsubscribe from this discussion, e-mail: [[email protected]].