Re: cvs2git: redundant M-lines

On 07/01/2014 02:16 PM, Matwey V. Kornilov wrote:
> I am running cvs2git trunk r5458. Attached here is shrunk repo. The
> issue is the following:
> 
> commit refs/heads/master
> mark :1000000013
> committer victor <> 1203457118 +0000
> data 16
> delay for light
> 
> M 100644 :13 etc/dome.cfg
> 
> commit refs/heads/TAG.FIXUP
> mark :1000000014
> committer cvs2git <> 1203457119 +0000
> data 167
> This commit was manufactured by cvs2svn to create tag 'dome-1_19'.
> 
> Sprout from master 2008-02-19 21:38:38 UTC victor 'delay for light'
> Delete:
>     server/callback.cpp
> from :1000000013
> M 100644 :13 etc/dome.cfg
> D server/callback.cpp
> 
> 
> Here, the M line in the commit :14 is redundant, because
> 1) there is only one child of :14 (which is :13)
> 2) blobids are the same, so the file has not been modified actually,
> there is no need to state it as modified :14

Thanks for the report.  It all sounds correct.  But is it actually
causing any problems (aside from an extra 26 characters in the
dumpfile)?  If not, I'd say that "fixing" the problem is not much of a
priority (though of course it's fine if somebody else wants to volunteer
to work on it).

Michael

-- 
Michael Haggerty
[email protected]

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1667&dsMessageId=3084329

To unsubscribe from this discussion, e-mail: [[email protected]].