Re: Better alignement of test list/results (cosmetic problem)
Michael Haggerty <[email protected]> Mon, 06 Apr 2015 11:46:25 +0200
| Newsgroups | gmane.comp.version-control.subversion.cvs2svn.devel |
|---|---|
| Message-ID | <[email protected]> |
On 04/06/2015 12:47 AM, sags wrote: > I attach here a suggested patch (split in 2 for readability) that > improves the alignment of test list/results printed by run_tests.py. >=20 > It is only a cosmetic change, the functionality is not modified at > all. Hi, These changes didn't apply to trunk/master. It looks like they are against version 2.4.0. So I applied them there then rebased to master. The first change is redundant with what is currently in master. The second needed some minor tweaking. In the future, it would be more convenient if you would submit patches against master. This change is in svntest, which comes originally from the Subversion project. If you look at svntest/update.sh, you'll see how we supposedly keep this directory updated with upstream. Normally your changes should be submitted to upstream and then synchronized to cvs2svn. But it has been more than two years since we last synchronized, and there have been a lot of upstream changes since then. I just tried updating, but our test suite doesn't work with the current version of svntest from upstream. So it seems we have a few alternatives: 1. Somebody steps forward to make our test suite work with the current upstream version of svntest. (I unfortunately have no time to work on this.= ) 2. Forget about ever synchronizing with upstream again. Then we can commit local tweaks whenever we want. 3. Some hybrid of the two, for example we apply your changes but accept that we might have to discard them if somebody ever volunteers for (1). 4. We drop your changes and kick the can down the road. Given that your changes are purely cosmetic, I lean towards (4) unless somebody volunteers for (1). Michael --=20 Michael Haggerty [email protected] ------------------------------------------------------ http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=3D1667&dsMessageId=3D= 3110919 To unsubscribe from this discussion, e-mail: [[email protected]= s.org].