Re: Where do CVS "descriptions" get stored?
Tim Landscheidt <[email protected]>
| Newsgroups | gmane.comp.version-control.subversion.cvs2svn.user |
|---|---|
| Organization | <URI:http://www.tim-landscheidt.de/> |
| Message-ID | <[email protected]> |
Michael Haggerty <[email protected]> wrote a long time ago: >>> [...] >>> If you submit a clean patch I would be happy to include it in the >>> cvs2svn source tree. >> I finally got around to take a look at it (despite your in- >> structions for dummies :-)); it works for me. Things to con- >> sider: [...] > I committed your patch to trunk as r4962. Thanks! Thanks. I noted one small typo where you missed an instance of "svn:description" (cf. attached patch). > [...] >> 3. Regarding the choice of property name: I agree that we shouldn't add >> something to the "svn:*" namespace (at least not without clearing it >> with the Subversion project first). But "dc:" seems rather obscure. >> The only property that we invent so far is called "cvs2svn:cvs-rev", and >> is set on a file to record the CVS revision number. (This is not a >> recommended feature but it is still supported.) So cvs2svn:description >> would be one possibility. But I don't see why the description (or >> cvs-rev!) has anything to do with cvs2svn; probably more appropriate >> names would be cvs:description and cvs:rev-num. Would you be OK with >> "cvs:description"? > [...] > I also made the property name used for CVS revision numbers changeable > by the user in r4967, though I didn't change the default. As the property name is configurable, I do not object to the default, but wanted to share my reasoning for choosing "dc:description" in the first place: While "cvs2svn:cvs-rev" does have an undeniable relationship to CVS and/or cvs2svn, the description - as *user-supplied* data - belongs to the file (like its name) and its property name should not be de- pendent on the (previously) used version control system. Therefore, I consider "dc:description" (or a similar gene- ric property name) more appropriate. But as I said, as long it is configurable I do not see much point in philosophical debates on a property name I seem to be the only one to use anyhow :-). Tim ------------------------------------------------------ http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1670&dsMessageId=2441592 To unsubscribe from this discussion, e-mail: [[email protected]].
cvs2svn-svn-description-typo.patch
(text/x-patch, 530 B)
Index: cvs2svn_lib/property_setters.py
===================================================================
--- cvs2svn_lib/property_setters.py (Revision 5030)
+++ cvs2svn_lib/property_setters.py (Arbeitskopie)
@@ -67,7 +67,7 @@
class DescriptionPropertySetter(SVNPropertySetter):
- """Set the svn:description property based on cvs_rev.cvs_file.description."""
+ """Set the cvs:description property based on cvs_rev.cvs_file.description."""
def __init__(self, propname='cvs:description'):
self.propname = propname