Re: KeyError in trunk

Hi Michael,

On Wed, May 19, 2010 at 03:55:47PM +0200, Michael Haggerty wrote:

> > I'm getting the following error in current trunk (r5122) while
> > converting a rather large repository:
> > 
> > ----- pass 4 (FilterSymbolsPass) -----
> > Filtering out excluded symbols and summarizing items...
> > Traceback (most recent call last):
> >   File "/usr/local/bin/cvs2svn", line 70, in <module>
> >     svn_main(os.path.basename(sys.argv[0]), sys.argv[1:])
> >   File "/usr/local/lib64/python2.6/site-packages/cvs2svn_lib/main.py", line 111, in svn_main
> >     main(progname, run_options, pass_manager)
> >   File "/usr/local/lib64/python2.6/site-packages/cvs2svn_lib/main.py", line 94, in main
> >     pass_manager.run(run_options)
> >   File "/usr/local/lib64/python2.6/site-packages/cvs2svn_lib/pass_manager.py", line 181, in run
> >     the_pass.run(run_options, stats_keeper)
> >   File "/usr/local/lib64/python2.6/site-packages/cvs2svn_lib/passes.py", line 486, in run
> >     revision_collector.process_file(cvs_file_items)
> >   File "/usr/local/lib64/python2.6/site-packages/cvs2svn_lib/checkout_internal.py", line 599, in process_file
> >     _Sink(self, cvs_file_items),
> >   File "/usr/local/lib64/python2.6/site-packages/cvs2svn_rcsparse/__init__.py", line 44, in parse
> >     return Parser().parse(file, sink)
> >   File "/usr/local/lib64/python2.6/site-packages/cvs2svn_rcsparse/common.py", line 473, in parse
> >     self.parse_rcs_deltatext()
> >   File "/usr/local/lib64/python2.6/site-packages/cvs2svn_rcsparse/common.py", line 446, in parse_rcs_deltatext
> >     self.sink.set_revision_info(revision, log, text)
> >   File "/usr/local/lib64/python2.6/site-packages/cvs2svn_lib/checkout_internal.py", line 479, in set_revision_info
> >     cvs_rev_id = self.cvs_file_items.original_ids[revision]
> > KeyError: '1.57.4.4.8.1'
> > 
> > It takes in the order of 10 or 14 minutes until the error appears and I
> > can reproduce it by running pass 4 again. May this error be caused by
> > excluding symbols (via ExcludeRegexpStrategyRule)?
 
I checked it using cvs2svn 2.3.0 and this works.

> A crash like this *shouldn't* happen in any case, assuming it occurs
> when you run a conversion from the start with a non-crazy configuration.
>  (Though it is conceivable that it could result from corruption in your
> CVS repository.)  Please report it as a bug, including a reproducible
> test case and the other usual information.

Then I'll need to patch cvs2svn first since there is no indication of
any file which might cause this. The repository has 46510 files...

Could you propose a little patch for cvs2svn_lib/checkout_internal.py -
I do not see an obvious way to get the file which is causing this.
Maybe it would be useful to catch the KeyError and report the file as
well.

Thanks,

Tino.

-- 
"What we nourish flourishes." - "Was wir nähren erblüht."

www.lichtkreis-chemnitz.de
www.tisc.de

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1670&dsMessageId=2611275

To unsubscribe from this discussion, e-mail: [[email protected]].