Re: Error in conversion when changing keyword handling to "expanded'
Michael Haggerty <[email protected]>
| Newsgroups | gmane.comp.version-control.subversion.cvs2svn.user |
|---|---|
| Message-ID | <[email protected]> |
On 01/25/2012 02:10 AM, Maciek Sakrejda wrote: > I'm working on converting the PostgreSQL JDBC CVS repository to git > using cvs2git, and I ran into the following error running on trunk > (r5367): > > ----- pass 4 (FilterSymbolsPass) ----- > Filtering out excluded symbols and summarizing items... > Traceback (most recent call last): [...] > File "/home/maciek/jdbc-to-git/cvs2svn-trunk/cvs2svn_lib/keyword_expander.py", > line 60, in author > return Ctx()._metadata_db[self.cvs_rev.metadata_id].original_author > AttributeError: Ctx instance has no attribute '_metadata_db' > > The conversion script worked fine until I changed the > KeywordHandlingPropertySetter from 'collapsed' to 'expanded'. Any > thoughts? I dug into this a little bit and it looks like it may be due > to the fact that the single-underscore-prefixed properties are > temporary, but I have no idea what the solution would be. I can > provide full repro steps if the stack trace is not enough. Thanks for the bug report. The problem is that usually the metadata database is not needed in pass4, so it wasn't being initialized. But in the particular case of using GitRevisionCollector with "expand" turned on and an "author" needs to be expanded, then the metadata database is needed. This should be fixed by r5374 in trunk. Please let me know if this fixes your problem. Michael -- Michael Haggerty [email protected] http://softwareswirl.blogspot.com/ ------------------------------------------------------ http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1670&dsMessageId=2910969 To unsubscribe from this discussion, e-mail: [[email protected]].