Re: Feature request: "Surrogate" repository root for $Header$ and $Source$ keyword expansion?

On 01/27/2012 12:35 PM, Maciek Sakrejda wrote:
> Great! How is the attached for a start? It passes the
> cvs_surrogate_root through set_project and uses that (if specified) as
> proposed. I haven't added any tests or sample config file docs yet,
> but is this the right approach? It seems to work on my repository.

Your patch seems about right, as far as it goes.  Comments:

1. The same thing can be done for cvs2svn.  The place to add the new
argument is in svn_run_options.py, SVNRunOptions.add_project().
(Supporting the options for all back-ends is not only helpful but also
makes documenting it easier.)

2. If you want to add a command-line argument for settings this option,
it would be done in RunOptions._get_conversion_options_group() and
documented via optparse and also in www/cvs2svn.html.

For testing, you might want to use the internal-co-keywords repository,
something like the internal_co_keywords() test.

Michael

-- 
Michael Haggerty
[email protected]
http://softwareswirl.blogspot.com/

------------------------------------------------------
http://cvs2svn.tigris.org/ds/viewMessage.do?dsForumId=1670&dsMessageId=2911837

To unsubscribe from this discussion, e-mail: [[email protected]].