Re: svn commit: r1934221 - subversion/trunk/.github/workflows

On Fri, 15 May 2026 at 15:38, <[email protected]> wrote:

> Author: jun66j5
> Date: Fri May 15 13:38:15 2026
> New Revision: 1934221
>
> Log:
> gha: Enable all features on CI build with cmake.
>
> * .github/workflows/cmake.yml
>   (Install dependencies (Windows, vcpkg)):
>     Add gettext[tools] and pdcurses.
>   (Install dependencies (Linux, apt-get)):
>     Add apache-dev, gettext, libncurses-dev.
>   (Install dependencies (Mac OS, homebrew)):
>     Add gettext and ncurses.
>   (Configure CMake):
>     Enable all features.
>
> [...]


>
> @@ -180,10 +184,16 @@ jobs:
>
>        - name: Configure CMake
>          run: >
> +          if ($env:RUNNER_OS -eq 'Windows') {
> +            $env:PATH += ";${env:VCPKG_ROOT}\installed\${{
> matrix.vcpkg_triplet }}\bin";
> +          };
>
A small nitpick: it looks like this part was not mentioned in the log
message.

Could you clarify the purpose of this change? I think that cmake/vcpkg
should work without needing a workaround like this. And if it's not
working, we should probably address the root cause in our CMake
implementation.

[...]


>            cmake -B out
>            -DBUILD_SHARED_LIBS=${{ matrix.build_shared }}
>            -DSVN_ENABLE_TESTS=ON
>            -DSVN_ENABLE_RA_SERF=ON
> +          -DSVN_ENABLE_NLS=ON
> +          -DSVN_ENABLE_APACHE_MODULES=${{ runner.os != 'Windows' && 'ON'
> || 'OFF' }}
> +          -DSVN_ENABLE_TUI=ON
>            -DCMAKE_INSTALL_PREFIX=${{ github.workspace }}/installdir
>            -DVCPKG_TARGET_TRIPLET=${{ matrix.vcpkg_triplet }}
>            -DSVN_TEST_CONFIGURE_FOR_PARALLEL=ON
>
>

-- 
Ivan Zhakov