Re: svn commit: r1935586 - in subversion/branches/xml-schema-validation-improvements: . build subversion/tests/cmdline subversion/tests/cmdline/svntest

Den tis 23 juni 2026 kl 15:34 skrev <[email protected]>:

> Author: ivan
> Date: Tue Jun 23 13:33:58 2026
> New Revision: 1935586
>
> Log:
> On 'xml-schema-validation-improvements' branch:
>
> Always use installed lxml and rnc2rng Python packages to validate XML
> output
> of `svn --xml` in tests.
>
> This change also makes these package mandatory for running tests unless new
> option `--disable-xml-schema-validation` is specified.
>

[...]

I had a few minutes to spare this afternoon so I checked this commit and
did three tests on Ubuntu 26.04:
- With python3-lxml install: make check succceeded
- Without python3-lxml installed: make check failed  with error messages,
this in the summary:
[[[
There were some XML validation errors,
checking/home/dsg/svn_branches/xml-schema-validation-improvements/tests.log
XML: Module lxml.etree not found
]]]
- Without python3-lxml:  DISABLE_XML_SCHEMA_VALIDATION=true make check
succeed.

I think this looks good - fails by default but can be made to work.

I also tried cmake/ctest but that failed spectacularly with (62 tests
failed) or without lxml (61 tests failed!), so I presume something else is
wrong.

Only thing remaining is to document this. "make check" is only mentioned
under "Building from a Tarball". Maybe it deserves a separate section ("D.
Running the test suite"). Possibly even restructuring "II. Installation" to
separate our three build systems (autoconf/make, vcproj and CMake) and
having a separate section on testing under each? Do we do this on the
branch or after merging back to trunk?

Cheers,
Daniel