Re: svn commit: r1935776 - in subversion/trunk: . .github/workflows build subversion/libsvn_subr/utf8proc subversion/tests/cmdline subversion/tests/cmdline/svntest

Jun Omae <[email protected]> writes:

> +    set(test_args
> +      --bin ${binary_dir}
> +      --tools-bin ${binary_dir}
> +      --verbose
> +      --log-to-stdout
> +      --set-log-level=WARNING
> +      --cleanup
> +    )
> +    if(SVN_TEST_CHECK_XML_SCHEMA)
> +      list(APPEND test_args --check-xml-schema)
> +    endif()
> +    list(APPEND test_args
> +      ${SVN_TEST_COMMAND_ARGUMENTS}
> +      ${CMAKE_CURRENT_SOURCE_DIR}
> +      ${test_root}
> +      "${prog}"
> +    )
> +
>      add_test(
>        NAME
>          "${name}"
>        COMMAND
> -        "${Python3_EXECUTABLE}" "${run_tests_script}"
> -        --bin ${binary_dir}
> -        --tools-bin ${binary_dir}
> -        --verbose
> -        --log-to-stdout
> -        --set-log-level=WARNING
> -        --cleanup
> -        $<$<BOOL:${SVN_TEST_CHECK_XML_SCHEMA}>:--check-xml-schema>
> -        ${SVN_TEST_COMMAND_ARGUMENTS}
> -        ${CMAKE_CURRENT_SOURCE_DIR}
> -        ${test_root}
> -        "${prog}"
> +        "${Python3_EXECUTABLE}" "${run_tests_script}" ${test_args}
>        WORKING_DIRECTORY
>          ${test_root}
>      )

+1.

I can confirm that running `ctest --verbose -R cmdline.authz_tests` fails on
Unix and Windows without the fix (due to an additional "" argument in the
command-line).  With the fix, it seems to work correctly.

Not sure how I missed this when voting for the corresponding nomination,
although that time I was running the tests from within Visual Studio.


Thanks,
Evgeny Kotkov