Re: [PATCH] Don't embed URLs in translation strings

Den sön 19 juli 2026 kl 18:36 skrev Timofei Zhakov <[email protected]>:

> I noticed that there are a few warnings when rolling a tar-ball related to
> localisation:
>
> [[[
> ../libsvn_subr/version.c:147: warning: Message contains an embedded URL.
> Better move it out of the translatable string, see
> https://www.gnu.org/software/gettext/manual/html_node/No-embedded-URLs.html
> ../svn/help-cmd.c:93: warning: Message contains an embedded URL.  Better
> move it out of the translatable string, see
> https://www.gnu.org/software/gettext/manual/html_node/No-embedded-URLs.html
> ../libsvn_fs_fs/fs_fs.c:445: warning: Message contains an embedded URL.
> Better move it out of the translatable string, see
> https://www.gnu.org/software/gettext/manual/html_node/No-embedded-URLs.html
> ../libsvn_wc/wc_db_wcroot.c:329: warning: Message contains an embedded
> URL.  Better move it out of the translatable string, see
> https://www.gnu.org/software/gettext/manual/html_node/No-embedded-URLs.html
> ]]]
>
> Seems like it's not the best practice to have strings that carry the URL
> directly but they rather suggest to sprintf/printf it into it later. I
> think it makes sense.
>
> The question that I have is do we really care or it'd mess it up even
> more. I assume it's better to update the PO files in the same commit (which
> should be a simple find and replace but I didn't include it in the patch).
>

It is a bunch of work and I don't think I could be bothered. However if you
feel like changing it I don't see a big problem. Only, as you say, we
should update the PO files to make sure they are correct.


Cheers,
/Daniel

>