Re: svn commit: r1936422 - subversion/trunk

On Wed, Jul 22, 2026 at 3:32 AM Timofei Zhakov <[email protected]> wrote:
>
> I think here you've changed the behaviour by using the configure time environment instead of the one when tests are run (which I assume ENVIRONMENT_MODIFICATION does). This is not mentioned in the log message.
>
> Btw, did you consider simply requiring more modern cmake when swig bindings are enabled? I remember before we bumped to 3.14 from 3.12 there was logic to still force cmake 3.14/3.13 (I don't remember the exact version) for the bindings. The default config should not be affected by this but the bindings (I assume a lot of consumers don't compile them) - in this case they will have to get a newer cmake.
>
> --
> Timofei Zhakov

That might be r1932396 ?

After r1934847, the CheckCompilerFlag is used but the module is
introduced in 3.19.
See also https://cmake.org/cmake/help/latest/module/CheckCompilerFlag.html

[[[
$ ../cmake-build.sh --cmake=3.14
Configurations:
  apxs: /usr/bin/apxs2
  cmake: /home/jun66j5/cmake/3.14/bin/cmake
  ctest: /home/jun66j5/cmake/3.14/bin/ctest
  ctest args:
  java: /usr/bin/java
  perl: /usr/bin/perl
  pod2man: /usr/bin/pod2man
  py3c: /home/jun66j5/src/subversion/py3c-1.4/include
  python: /usr/bin/python3
  ruby: /usr/bin/ruby
  swig: /home/jun66j5/swig/3.0.12/bin/swig
  builddir: /dev/shm/svn-cmake-build.1kNkr/build

-- The C compiler identification is GNU 11.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- The CXX compiler identification is GNU 11.4.0
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found SWIG: /home/jun66j5/swig/3.0.12/bin/swig (found version "3.0.12")
CMake Error at CMakeLists.txt:339 (include):
  include could not find load file:

    CheckCompilerFlag


CMake Error at CMakeLists.txt:343 (check_compiler_flag):
  Unknown CMake command "check_compiler_flag".
Call Stack (most recent call first):
  CMakeLists.txt:366 (SVN_CFLAGS_ADD_IFELSE)


-- Configuring incomplete, errors occurred!
See also "/dev/shm/svn-cmake-build.1kNkr/build/CMakeFiles/CMakeOutput.log".
]]]

After the changes for CheckCompilerFlag are commented temporarily, the
following error is occurred.
The Intl::Intl is added in 3.20.
See https://cmake.org/cmake/help/latest/module/FindIntl.html

[[[
-- Found Intl: /usr/include
CMake Error at CMakeLists.txt:453 (add_library):
  add_library cannot create ALIAS target "external-intl" because target
  "Intl::Intl" is imported but not globally visible.
]]]

Currently, the minimum required version 3.14 is not met. At least, it
seems that 3.20 is needed. If the minimum required is important, I
think we should run the build, test and install in the CI with the
minimum version of cmake.

-- 
Jun Omae <[email protected]> (大前 潤)