Re: svn commit: r1936631 - in subversion/trunk: . subversion/tests/libsvn_fs_fs

--000000000000f9b30d0657a8482c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 28 Jul 2026 at 10:29, Daniel Sahlberg <[email protected]>
wrote:

> Den m=C3=A5n 27 juli 2026 kl 12:48 skrev <[email protected]>:
>
>> Author: ivan
>> Date: Mon Jul 27 10:48:05 2026
>> New Revision: 1936631
>>
>
> ...
>
>> +    /* Create 10 revisions. */
>> +    for (i =3D 1; i < 10; ++i)
>> +      {
>> +        svn_fs_txn_t *txn;
>> +        svn_fs_root_t *txn_root;
>> +        svn_revnum_t new_rev =3D 0;
>> +
>> +        svn_pool_clear(iterpool);
>> +
>> +        SVN_ERR(svn_fs_begin_txn(&txn, fs, new_rev, iterpool));
>> +        SVN_ERR(svn_fs_txn_root(&txn_root, txn, iterpool));
>> +        SVN_ERR(svn_fs_make_dir(txn_root, apr_itoa(pool, i), iterpool))=
;
>>
>
> Is it intentional to use pool instead of iterpool in the call to apr_itoa=
?
>
>
No, it was not intentional. I copied this code from other test and didn't
check it properly.
Fixed in r1936661 <https://svn.apache.org/r1936661>.

And I also fixed the code I copied from in r1936662
<https://svn.apache.org/r1936662>.

Thanks!

--=20
Ivan Zhakov

--000000000000f9b30d0657a8482c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, 28 Jul 2026 at 10:29, Daniel Sahl=
berg &lt;<a href=3D"mailto:[email protected]">daniel.l.sahlberg@g=
mail.com</a>&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_containe=
r"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div =
dir=3D"ltr"><span style=3D"background-color:transparent">Den m=C3=A5n 27 ju=
li 2026 kl 12:48 skrev &lt;<a href=3D"mailto:[email protected]" target=3D"_bl=
ank">[email protected]</a>&gt;:</span></div><div class=3D"gmail_quote"><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex">Author: ivan<br>
Date: Mon Jul 27 10:48:05 2026<br>
New Revision: 1936631<br></blockquote><div><br></div><div>...</div><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px=
 solid rgb(204,204,204);padding-left:1ex">
+=C2=A0 =C2=A0 /* Create 10 revisions. */<br>
+=C2=A0 =C2=A0 for (i =3D 1; i &lt; 10; ++i)<br>
+=C2=A0 =C2=A0 =C2=A0 {<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_fs_txn_t *txn;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_fs_root_t *txn_root;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_revnum_t new_rev =3D 0;<br>
+<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_pool_clear(iterpool);<br>
+<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 SVN_ERR(svn_fs_begin_txn(&amp;txn, fs, new_rev=
, iterpool));<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 SVN_ERR(svn_fs_txn_root(&amp;txn_root, txn, it=
erpool));<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 SVN_ERR(svn_fs_make_dir(txn_root, apr_itoa(poo=
l, i), iterpool));<br></blockquote><div><br></div><div>Is it intentional to=
 use pool instead of iterpool in the call to apr_itoa?</div><div>=C2=A0</di=
v></div></div></blockquote><div>No, it was not intentional. I copied this c=
ode from other test and didn&#39;t check it properly.</div><div>Fixed in r<=
a href=3D"https://svn.apache.org/r1936661">1936661</a>.</div><div><br></div=
><div>And I also fixed the code I copied from in r<a href=3D"https://svn.ap=
ache.org/r1936662">1936662</a>.</div></div><div><br></div><div>Thanks!</div=
><div><br></div><span class=3D"gmail_signature_prefix">-- </span><br><div d=
ir=3D"ltr" class=3D"gmail_signature">Ivan Zhakov</div></div>

--000000000000f9b30d0657a8482c--