Re: svn commit: r1936422 - subversion/trunk

--000000000000c378f70657bdfb60
Content-Type: text/plain; charset="UTF-8"

On Thu, 23 Jul 2026 at 18:04, Jun Omae <[email protected]> wrote:

[..]

> > After the changes for CheckCompilerFlag are commented temporarily, the
> > following error is occurred.
> > The Intl::Intl is added in 3.20.
> > See https://cmake.org/cmake/help/latest/module/FindIntl.html
> >
> > [[[
> > -- Found Intl: /usr/include
> > CMake Error at CMakeLists.txt:453 (add_library):
> >   add_library cannot create ALIAS target "external-intl" because target
> >   "Intl::Intl" is imported but not globally visible.
> > ]]]
> >
>
> Fixed in r1936526.
>
> It looks the workaround from r1936526 is no longer needed since we bumped
CMake minimum required version to 3.20 (r1936635)

I have tested build with CMake 3.20 and r1936526 reverted: the build works
fine.

So I suggested to revert  r1936526.

WDYT?

-- 
Ivan Zhakov

--000000000000c378f70657bdfb60
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, 23 Jul 2026 at 18:04, Jun Omae &l=
t;<a href=3D"mailto:[email protected]">[email protected]</a>&gt; wrote:</di=
v><div class=3D"gmail_quote gmail_quote_container"><div>=C2=A0</div><div>[.=
.]=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; After the changes for CheckCompilerFlag are commented temporarily, the=
<br>
&gt; following error is occurred.<br>
&gt; The Intl::Intl is added in 3.20.<br>
&gt; See <a href=3D"https://cmake.org/cmake/help/latest/module/FindIntl.htm=
l" rel=3D"noreferrer" target=3D"_blank">https://cmake.org/cmake/help/latest=
/module/FindIntl.html</a><br>
&gt; <br>
&gt; [[[<br>
&gt; -- Found Intl: /usr/include<br>
&gt; CMake Error at CMakeLists.txt:453 (add_library):<br>
&gt;=C2=A0 =C2=A0add_library cannot create ALIAS target &quot;external-intl=
&quot; because target<br>
&gt;=C2=A0 =C2=A0&quot;Intl::Intl&quot; is imported but not globally visibl=
e.<br>
&gt; ]]]<br>
&gt; <br>
<br>
Fixed in r1936526.<br>
<br></blockquote></div><div>It looks the workaround from=C2=A0r1936526 is n=
o longer needed since we bumped CMake minimum required version to 3.20 (r19=
36635)=C2=A0</div><div><br></div><div>I have tested build with CMake 3.20 a=
nd r1936526 reverted: the build works fine.</div><div><br></div><div>So I s=
uggested to revert=C2=A0
r1936526.</div><div><br></div><div>WDYT?</div><div><br></div><span class=3D=
"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_sign=
ature">Ivan Zhakov</div></div>

--000000000000c378f70657bdfb60--