Re: svn commit: r1936422 - subversion/trunk

--000000000000cbb35d0657e5b3b3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 29 Jul 2026 at 18:34, Jun Omae <[email protected]> wrote:

> On Wed, Jul 29, 2026 at 8:09=E2=80=AFPM Ivan Zhakov <[email protected]> wro=
te:
> >
> > On Thu, 23 Jul 2026 at 18:04, Jun Omae <[email protected]> wrote:
> >
> > [..]
> >>
> >> > After the changes for CheckCompilerFlag are commented temporarily, t=
he
> >> > following error is occurred.
> >> > The Intl::Intl is added in 3.20.
> >> > See https://cmake.org/cmake/help/latest/module/FindIntl.html
> >> >
> >> > [[[
> >> > -- Found Intl: /usr/include
> >> > CMake Error at CMakeLists.txt:453 (add_library):
> >> >   add_library cannot create ALIAS target "external-intl" because
> target
> >> >   "Intl::Intl" is imported but not globally visible.
> >> > ]]]
> >> >
> >>
> >> Fixed in r1936526.
> >>
> > It looks the workaround from r1936526 is no longer needed since we
> bumped CMake minimum required version to 3.20 (r1936635)
> >
> > I have tested build with CMake 3.20 and r1936526 reverted: the build
> works fine.
> >
>
> See cmake 3.18 release notes,
> https://cmake.org/cmake/help/latest/release/3.18.html#commands
>
> > The add_library() and add_executable() commands learned to create Alias
> Targets referencing non-GLOBAL Imported Targets.
>
> The workaround is no longer needed for cmake 3.18 or later.
>
>

> > So I suggested to revert  r1936526.
> >
> > WDYT?
> >
>
> I have no objection.
>
> Done in  r1936758 <https://svn.apache.org/r1936758>.

Thanks!

--=20
Ivan Zhakov

--000000000000cbb35d0657e5b3b3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Wed, 29 Jul 2026 at 18:34, Jun Omae &l=
t;<a href=3D"mailto:[email protected]">[email protected]</a>&gt; wrote:</di=
v><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex">On Wed, Jul 29, 2026 at 8:09=E2=80=AFPM Ivan Zhak=
ov &lt;<a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]=
</a>&gt; wrote:<br>
&gt;<br>
&gt; On Thu, 23 Jul 2026 at 18:04, Jun Omae &lt;<a href=3D"mailto:jun66j5@g=
mail.com" target=3D"_blank">[email protected]</a>&gt; wrote:<br>
&gt;<br>
&gt; [..]<br>
&gt;&gt;<br>
&gt;&gt; &gt; After the changes for CheckCompilerFlag are commented tempora=
rily, the<br>
&gt;&gt; &gt; following error is occurred.<br>
&gt;&gt; &gt; The Intl::Intl is added in 3.20.<br>
&gt;&gt; &gt; See <a href=3D"https://cmake.org/cmake/help/latest/module/Fin=
dIntl.html" rel=3D"noreferrer" target=3D"_blank">https://cmake.org/cmake/he=
lp/latest/module/FindIntl.html</a><br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; [[[<br>
&gt;&gt; &gt; -- Found Intl: /usr/include<br>
&gt;&gt; &gt; CMake Error at CMakeLists.txt:453 (add_library):<br>
&gt;&gt; &gt;=C2=A0 =C2=A0add_library cannot create ALIAS target &quot;exte=
rnal-intl&quot; because target<br>
&gt;&gt; &gt;=C2=A0 =C2=A0&quot;Intl::Intl&quot; is imported but not global=
ly visible.<br>
&gt;&gt; &gt; ]]]<br>
&gt;&gt; &gt;<br>
&gt;&gt;<br>
&gt;&gt; Fixed in r1936526.<br>
&gt;&gt;<br>
&gt; It looks the workaround from r1936526 is no longer needed since we bum=
ped CMake minimum required version to 3.20 (r1936635)<br>
&gt;<br>
&gt; I have tested build with CMake 3.20 and r1936526 reverted: the build w=
orks fine.<br>
&gt;<br>
<br>
See cmake 3.18 release notes,<br>
<a href=3D"https://cmake.org/cmake/help/latest/release/3.18.html#commands" =
rel=3D"noreferrer" target=3D"_blank">https://cmake.org/cmake/help/latest/re=
lease/3.18.html#commands</a><br>
<br>
&gt; The add_library() and add_executable() commands learned to create Alia=
s Targets referencing non-GLOBAL Imported Targets.<br>
<br>
The workaround is no longer needed for cmake 3.18 or later.<br>
<br></blockquote><div>=C2=A0</div><div></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex">
&gt; So I suggested to revert=C2=A0 r1936526.<br>
&gt;<br>
&gt; WDYT?<br>
&gt;<br>
<br>
I have no objection.<br>
<br></blockquote><div>Done in=C2=A0 r<a href=3D"https://svn.apache.org/r193=
6758">1936758</a>.</div><br></div><div class=3D"gmail_quote gmail_quote_con=
tainer">Thanks!</div><br><span class=3D"gmail_signature_prefix">-- </span><=
br><div dir=3D"ltr" class=3D"gmail_signature">Ivan Zhakov</div></div>

--000000000000cbb35d0657e5b3b3--