Re: [PATCH] INSTALL: clarify that libserf is auto-detected by pkg-config

--0000000000005ad8c1065833d745
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Den m=C3=A5n 3 aug. 2026 kl 19:02 skrev Pavel Lyalyakin via dev <
[email protected]>:

> Hello,
>
> INSTALL says that I have to explicitly specify --with-serf when running
> ./configure to enable ra_serf. This doesn't seem to be the case because
> pkg-config is used to automatically detect whether libserf is installed o=
n
> the system.
>
> (I think that the current wording is from the ra_neon era, when
> --with-serf selected ra_serf instead of ra_neon).
>

I see that the existing text use the word "place" but for all other uses
(except for BDB) we use the word "location" so I would take the opportunity
to change it here.

I would suggest to add something about "if you don't have pkg-config
installed" (as you already discovered in an earlier mail onlist[1] ). I do
see that we mention pkg-config elsewhere and I assume the same issue occur
for all dependencies if you don't have pkg-config installed so maybe that
is something that could go into section I.C.14?

If you want to add the pkg-config related note under the Serf headline,
maybe something like:

"If you don't use pkg-config and serf is installed in a non-standard
location, you should use"

Whichever way you choose, you have my +1 to edit INSTALL as you see fit,
either this patch or a variation thereof.

Thanks,
Daniel


[1] https://lists.apache.org/thread/7f51kjmlxqls7nql8q5v0l22f0m5c372


>
> Log message:
>
> * INSTALL
>   (I.C.7): clarify that libserf is automatically detected by pkg-config
>
> Patch by: Pavel Lyalyakin <[email protected]>
>
> --
> With best regards,
> Pavel Lyalyakin
> VisualSVN Team
>

--0000000000005ad8c1065833d745
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><span style=3D"backgroun=
d-color:transparent">Den m=C3=A5n 3 aug. 2026 kl 19:02 skrev Pavel Lyalyaki=
n via dev &lt;</span><a href=3D"mailto:[email protected]" target=3D=
"_blank" style=3D"background-color:transparent">[email protected]</=
a><span style=3D"background-color:transparent">&gt;:</span></div><div class=
=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=
=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div>Hello,</div><div><br></div>=
<div>INSTALL says that I have to explicitly specify --with-serf when runnin=
g ./configure to enable ra_serf. This doesn&#39;t seem to be the case becau=
se pkg-config is used to automatically detect whether libserf is installed =
on the system.</div><div><br></div><div>(I think that the current wording i=
s from the ra_neon era, when --with-serf selected ra_serf instead of ra_neo=
n).</div></div></div></div></blockquote><div><br></div><div>I see that the =
existing text use the word &quot;place&quot; but for all other uses (except=
 for BDB) we use the word &quot;location&quot; so I would take the opportun=
ity to change it here.</div><div><br></div><div>I would suggest to add some=
thing about &quot;if you don&#39;t have pkg-config installed&quot; (as you =
already discovered in an earlier mail onlist[1] ). I do see that we mention=
 pkg-config elsewhere and I assume the same issue occur for all dependencie=
s if you don&#39;t have pkg-config installed so maybe that is something tha=
t could go into section I.C.14?</div><div><br></div><div>If you want to add=
 the pkg-config related note under the Serf headline, maybe something like:=
</div><div><br></div><div>&quot;If you don&#39;t use pkg-config and serf is=
 installed in a non-standard location, you should use&quot;</div><div><br><=
/div><div>Whichever way you choose, you have=C2=A0<span style=3D"background=
-color:transparent">my=C2=A0</span><span style=3D"background-color:transpar=
ent">+1 to edit INSTALL as you see fit, either this patch or a variation th=
ereof.</span></div><div><span style=3D"background-color:transparent"><br></=
span></div><div><span style=3D"background-color:transparent">Thanks,</span>=
</div><div><span style=3D"background-color:transparent">Daniel</span></div>=
<div><br></div><div><br></div><div><span style=3D"background-color:transpar=
ent">[1]=C2=A0<a href=3D"https://lists.apache.org/thread/7f51kjmlxqls7nql8q=
5v0l22f0m5c372">https://lists.apache.org/thread/7f51kjmlxqls7nql8q5v0l22f0m=
5c372</a></span></div><div>=C2=A0</div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div><br><=
/div><div>Log message:</div><div><br></div><div>
<div>* INSTALL</div><div>=C2=A0 (I.C.7): clarify that libserf is automatica=
lly detected by pkg-config</div><div><br></div><div>Patch by: Pavel Lyalyak=
in &lt;<a href=3D"mailto:[email protected]" target=3D"_blank">lyalyakin@=
apache.org</a>&gt;</div>

<br></div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"=
ltr" class=3D"gmail_signature"><font color=3D"#888888">With best regards,<b=
r>
Pavel Lyalyakin<br>
VisualSVN Team</font></div></div>
</div>
</div>
</blockquote></div>
</div>
</div>

--0000000000005ad8c1065833d745--