[jira] [Commented] (SVN-4732) Subversion crashes during local (file://) checkout on Windows

    [ https://issues.apache.org/jira/browse/SVN-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735279#comment-16735279 ] 

Daniel Shahaf (äñ§€¥£¢) commented on SVN-4732:
----------------------------------------------

Yeah, it's definitely a bug for it to say "Checked out revision 9" if it didn't even create a directory.

I don't have windows to test, but if you'd like to investigate further, I'd start by adding all these URLs to subversion/tests/libsvn_subr/dirent_uri-test.c and making sure they canonicalize and parse to the correct values. Let's move any further discussion to dev@ (we don't hold discussions on jira).

> Subversion crashes during local (file://) checkout on Windows
> -------------------------------------------------------------
>
>                 Key: SVN-4732
>                 URL: https://issues.apache.org/jira/browse/SVN-4732
>             Project: Subversion
>          Issue Type: Bug
>          Components: libsvn_subr
>    Affects Versions: 1.9.7, 1.10.0-alpha3
>         Environment: {noformat}
> PS > [System.Environment]::OSVersion.Version
> Major Minor Build Revision
> ----- ----- ----- --------
> 10 0 16299 0{noformat}
> Tried two different Subversion clients:
> {noformat}
> PS > svn --version
> svn, version 1.9.7 (r1800392)
> compiled Aug 8 2017, 22:14:48 on x86-microsoft-windows{noformat}
> {noformat}
> PS > D:\Entwicklung\Programme\svn-1.10.0-alpha3\svn.exe --version
> svn, version 1.10.0-alpha3 (Alpha 3)
> compiled Aug 22 2017, 08:13:12 on x86_64-microsoft-windows10.0.14393{noformat}
>            Reporter: Michael Osipov
>            Priority: Major
>
> Ported from: [https://svn.haxx.se/users/archive-2018-03/0115.shtml].
> Running on Windows from PowerShell:
> {noformat}
> PS > svn co file://D:\Entwicklung\svn-repos\scm-svn-test-at-sign .
> svn: E235000: In file 'D:\Development\SVN\Releases\TortoiseSVN-1.9.7\ext\subversion\subversion\libsvn_client\checkout.c' line 87: assertion failed (svn_uri_is_canonical(url, scratch_pool)){noformat}
> {noformat}
> PS > D:\Entwicklung\Programme\svn-1.10.0-alpha3\svn.exe co file://D:\Entwicklung\svn-repos\scm-svn-test-at-sign .
> svn: E235000: In file '..\..\..\subversion\libsvn_client\checkout.c' line 88: assertion failed (svn_uri_is_canonical(url, scratch_pool)){noformat}
> I know that the URL should start with {{file:///}}, but I would expect something like "invalid URL". The assert failed isn't really helpful to the user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)