[jira] [Comment Edited] (SVN-4840) Merge assertion failure in svn_sort__array_insert

    [ https://issues.apache.org/jira/browse/SVN-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019399#comment-17019399 ] 

Julian Foad edited comment on SVN-4840 at 2/10/20 1:28 PM:
-----------------------------------------------------------

Good news: the location of the error is nailed down.

The specific reported failure mode was using valid inputs ("canonical" rangelists) to svn_rangelist_merge2(). I can now ([r1872923|http://svn.apache.org/r1872923]) reproduce other similar failures of that function using random-input testing, which I initially was unable to reproduce.

Knowing the failure occurred with valid inputs to svn_rangelist_merge2(), there no longer any reason to assume that the root cause is an error in higher-level code. It is likely that the bug in svn_rangelist_merge2() is the root cause.

Other follow-up commits: r1872919, r1872921, r1872922, r1872923, r1872924, r1873294

 


was (Author: julianfoad):
Good news: the location of the error is nailed down.

The specific reported failure mode was using valid inputs ("canonical" rangelists) to svn_rangelist_merge2(). I can now ([r1872923|http://svn.apache.org/r1872923]) reproduce other similar failures of that function using random-input testing, which I initially was unable to reproduce.

Knowing the failure occurred with valid inputs to svn_rangelist_merge2(), there no longer any reason to assume that the root cause is an error in higher-level code. It is likely that the bug in svn_rangelist_merge2() is the root cause.

Other follow-up commits: r1872919, r1872921, r1872922, r1872924

 

> Merge assertion failure in svn_sort__array_insert
> -------------------------------------------------
>
>                 Key: SVN-4840
>                 URL: https://issues.apache.org/jira/browse/SVN-4840
>             Project: Subversion
>          Issue Type: Bug
>    Affects Versions: trunk, 1.10.6
>            Reporter: Julian Foad
>            Priority: Major
>
> I am investigating an assertion failure. I received a stack trace without parameter values, from which I quote the relevant part:
>  
> {code:java}
> #4 svn_sort__array_insert (array=?, new_element=?, insert_index=?)
>  at subversion/libsvn_subr/sorts.c:310
>  assert(0 <= insert_index && insert_index <= array->nelts);
> #5 svn_rangelist_merge2 (rangelist=?, chg=?,)
>  at subversion/libsvn_subr/mergeinfo.c:1231
>  svn_sort__array_insert(rangelist, &range_copy, i++);
> #6 svn_mergeinfo_merge2 (mergeinfo=?, changes=?,)
>  at subversion/libsvn_subr/mergeinfo.c:1838
> #7 combine_forked_mergeinfo_props (...)
>  at subversion/libsvn_wc/props.c:138
> #8 apply_single_mergeinfo_prop_change (...)
>  at subversion/libsvn_wc/props.c:1087
> {code}
> This was reported in Subversion 1.10.4. I have reproduced with 1.10.6 and trunk@1871000.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)