[jira] [Commented] (SVN-4857) Add PC Name to lock

    [ https://issues.apache.org/jira/browse/SVN-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103368#comment-17103368 ] 

Daniel Shahaf commented on SVN-4857:
------------------------------------

[~hartmannathan] Actually, I think there may be a valid feature request in here.  Ignore for the moment the use of the term "checkbox" — that might simply be shorthand for "a boolean knob", whatever its presentation — and consider functionality that the core libraries _do_ provide:

[[[
% svnadmin create r
% svnmucc -mm put /dev/null file://$PWD/r/iota 
r1 committed by daniel at 2020-05-09T16:45:35.474096Z
% svn lock file://$PWD/r/iota 
'file:///scratch/tmp.ogNhcfBAxk/r/iota' locked by user 'daniel'.
% svn info file://$PWD/r/iota
⋮
Lock Token: opaquelocktoken:e780ec7e-bf34-472a-86a7-a1356d139271
Lock Owner: daniel
Lock Created: 2020-05-09 16:45:39 +0000 (Sat, 09 May 2020)
% 
]]]

The request could be interpreted to mean the lock token should include the IP address of the locker.

I don't think we should do that by default for privacy reasons.

It _might_ be possible to implement this with a pre-lock hook, but I don't immediately see how the hook can learn the remote IP address.  (It might be possible to solve this for specific cases by hardcoding into the pre-lock hook knowledge of what RA method and MPM (or svnserve mode) are in use.)

So I think this request could be taken as a request that the the remote IP address should be passed to the pre-lock hook, whereupon the administrator could achieve the requested functionality by implementing an appropriate hook (probably just {{printf %s opaquelocktoken:${6}:$(uuidgen)}}).

[~Bullet9909] Could you clarify your request, please?

> Add PC Name to lock
> -------------------
>
>                 Key: SVN-4857
>                 URL: https://issues.apache.org/jira/browse/SVN-4857
>             Project: Subversion
>          Issue Type: New Feature
>         Environment: Windows
>            Reporter: Chris
>            Priority: Minor
>
> Add check box in configuration that appends the PC Name along with current user to the locked by field. I log into multiple PC's using the same user name, and modify a common repo on all of them. At the end of the day it gets confusing which PC's had specific locks. All I know is that they are all locked by my user name.
>  
> Thank you for your time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)