[jira] [Commented] (SVN-4890) multi-wc-format: should we forbid upgrading an external WC to mismatch its parent WC format?

    [ https://issues.apache.org/jira/browse/SVN-4890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508500#comment-17508500 ] 

Daniel Shahaf commented on SVN-4890:
------------------------------------

Here's a test for this:

{code}
Index: subversion/tests/cmdline/upgrade_tests.py
===================================================================
--- subversion/tests/cmdline/upgrade_tests.py	(revision 1899016)
+++ subversion/tests/cmdline/upgrade_tests.py	(working copy)
@@ -339,6 +339,12 @@ def upgrade_with_externals(sbox):
   expected_stderr = wc_is_too_old_regex
   svntest.actions.run_and_verify_svn(None, expected_stderr,
                                      'info', sbox.wc_dir)
+
+  # Verify that upgrading the external is rejected (issue #4890)
+  svntest.actions.run_and_verify_svn(None, svntest.verify.AnyOutput,
+                                     'upgrade',
+                                     sbox.ospath('A/C/exdir_H'))
+
   # Now upgrade the working copy
   svntest.actions.run_and_verify_svn(None, [],
                                      'upgrade', sbox.wc_dir)
{code}

> multi-wc-format: should we forbid upgrading an external WC to mismatch its parent WC format?
> --------------------------------------------------------------------------------------------
>
>                 Key: SVN-4890
>                 URL: https://issues.apache.org/jira/browse/SVN-4890
>             Project: Subversion
>          Issue Type: Improvement
>            Reporter: Julian Foad
>            Priority: Major
>              Labels: api
>             Fix For: 1.15.0
>
>
> Daniel Shahaf wrote, in dev@ email "multi-wc-format: upgrading externals" (https://mail-archives.apache.org/mod_mbox/subversion-dev/202202.mbox/%3C20220219144836.GA2817%40tarpaulin.shahaf.local2%3E):
> multi-wc-format/BRANCH-README mentioned this:
> > [*] New externals working copies must inherit the format from their
> > parent working copy, because mixed-format working copies are a) a
> > Bad Thing, and b) defeat the purpose of this feature, which is
> > support for multiple versions of the client in the same working
> > copy.
> Upgrading a parent working copy upgrades external wc's too. However,
> upgrading an external succeeds. Judging by the quoted remark, should
> «svn upgrade --compatible-version=$N /path/to/external» error out unless
> the external's parent working copy is already at version $V?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)