[jira] [Commented] (SVN-4891) Pristines-on-demand: fix disabled tests

    [ https://issues.apache.org/jira/browse/SVN-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518213#comment-17518213 ] 

Julian Foad commented on SVN-4891:
----------------------------------

{code:none}
    update_tests.py 57 skip_access_denied(): access denied paths should be skipped
       [[Need to update the access denied handling in update_editor.c]]{code}
A Windows-only test. A comment on the test says: "# Needs work: the access denied error now happens when we use the working file as the base in update_editor.c:apply_textdelta()."

(In principle I don't see why we shouldn't test a similar access-denied
​condition on unix-like systems, though the error code would be
​different. Maybe the answer is the semantics would be so different it
​would fail at a different place in the code path and so be a different
​test case. I don't plan to pursue this.)

I think the current state is this test will report XFAIL/WIMP with
​pristines-on-demand enabled (currently meaning WC format 32) and XPASS otherwise.

This test was introduced in r1143071 with the log message "Make svn
​update handle some access denied scenarios with a proper skip. This
makes it less likely that the database will be closed after updating with
working queue items left."

I would guess that gracefully handling the case where the working file
​on disk has this particular kind of OS lock isn't of primary concern.

> Pristines-on-demand: fix disabled tests
> ---------------------------------------
>
>                 Key: SVN-4891
>                 URL: https://issues.apache.org/jira/browse/SVN-4891
>             Project: Subversion
>          Issue Type: Bug
>            Reporter: Julian Foad
>            Assignee: Julian Foad
>            Priority: Major
>
> The following tests had been changed in the pristines-on-demand development.
> Most were disabled with the '@Wimp' decorator. (This caused some of them to give an XPASS and some an XFAIL result when run against the older WC format, and all XFAIL against the newer WC format.)
> They need to be re-enabled and fixed.
> (I am removing them from this list as and when fixed.)
> {code:java}
>     basic_tests.py 8 basic_commit_corruption(): basic corruption detection on commit
>       [[Relies on wc.text_base_path()]]
>     basic_tests.py 9 basic_update_corruption(): basic corruption detection on update
>       [[Relies on wc.text_base_path()]]
>     externals_tests.py ... ... ...:
>       update_modify_file_external(),
>       remap_file_external_with_prop_del(),
>       file_external_recorded_info():
>         existing issue (Windows only)
>     revert_tests.py 2 revert_reexpand_keyword(): revert reexpands manually contracted keyword
>       "See r1101730 and r1101817"
>     trans_tests.py 1 keywords_from_birth(): commit new files with keywords active from birth
>       [[Relies on wc.text_base_path()]]
>     trans_tests.py 3 eol_change_is_text_mod(): committing eol-style change forces text send
>       [[Relies on wc.text_base_path()]]
>     update_tests.py 57 skip_access_denied(): access denied paths should be skipped
>       [[Need to update the access denied handling in update_editor.c]]
>     upgrade_tests.py 16 replaced_files(): upgrade with base and working replaced files
>       - marked XFail in pristines-on-demand mode; passes with the old WC format.
>    {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)