[jira] [Commented] (SVN-4622) revert as root always notifies for files

    [ https://issues.apache.org/jira/browse/SVN-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18047521#comment-18047521 ] 

Daniel Sahlberg commented on SVN-4622:
--------------------------------------

An initial try was committed in r1915215 but after discussion during the release process of 1.15 it was decided to revert.

> revert as root always notifies for files
> ----------------------------------------
>
>                 Key: SVN-4622
>                 URL: https://issues.apache.org/jira/browse/SVN-4622
>             Project: Subversion
>          Issue Type: Bug
>          Components: libsvn_subr
>    Affects Versions: all
>            Reporter: Philip Martin
>            Priority: Minor
>
> $ svnadmin create repo
> $ svn import -mm repo/format file://`pwd`/repo/f
> $ umask 0022
> $ svn co file://`pwd`/repo wc
> $ sudo svn revert wc/f
> Reverted 'wc/f'
> The function svn_io__is_finfo_read_only() will check the world permissions when invoked with uid=root. A typical umask removes world write so this means that root sees every file as read-only. This causes the revert code to invoke svn_io_set_file_read_write() and notify. However svn_io_set_file_read_write() sets the owner permissions, an operation that succeeds when run as root, and obeys the umask so the world permissions remain read-only.
> Reported by:
> https://mail-archives.apache.org/mod_mbox/subversion-users/201602.mbox/%3C56C0738E.9010508%40i.ua%3E
> http://svn.haxx.se/users/archive-2016-02/0061.shtml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)