Re: svn commit: r40493 - in trunk/subversion: libsvn_fs_base libsvn_fs_fs libsvn_ra_neon libsvn_ra_serf tests/cmdline

Paul Burba wrote:
>> Should the error in the 'else' clause
> 
> I assume you mean the first error?  The error in the else clause if
> for when *no* valid current rev is specified.

Yes, right.  Mentally interpreted the SVN_IS_VALID_REVNUM in reverse.

>> there say something like, "Path 'foo'
>> doesn't exist in revision REV?" instead of mentioning "HEAD"?  Like I said,
>> maybe not -- I can't see enough of the function in your diff to know.
> 
> We shouldn't say that in either case.  If we are trying to lock a file
> in a WC then current_rev is that path's base revision

I didn't read this part of your previous mail well enough -- my bad:

 * If @a current_rev is a valid revnum, then do an out-of-dateness
 * check.  If the revnum is less than the last-changed-revision of @a
 * path (or if @a path doesn't exist in HEAD), return
 * #SVN_ERR_FS_OUT_OF_DATE.

So I'm guessing that args->current_rev is the working copy revision if you
do 'svn lock /path/to/working_copy', and SVN_INVALID_REVNUM if you do 'svn
lock URL'.  But regardless, the path check is versus HEAD, so the error
message should report it as such.  I get it now.  Carry on.

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2417722

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkr9uKQACgkQokEGqRcG/W5MfwCfQTKnRUI/8nDhC837HAEyYAYI
3mMAnRUCnPv0cnEsJAo5o/zTdofZ54QD
=lJ3s
-----END PGP SIGNATURE-----