Re: [PATCH] Extend 'svn diff URL URL' to 'svn diff URL URL [WC]'

Philip Martin <[email protected]> Thu, 03 Dec 2009 14:00:33 +0000
Newsgroups gmane.comp.version-control.subversion.devel,gmane.comp.version-control.subversion.rapidsvn.devel
Message-ID <[email protected]>
Julian Foad <[email protected]> writes:

> Philip Martin wrote:
>> Julian Foad <[email protected]> writes:
>> 
>> >> > > $ svn diff ^/repo/branches/foo ^/repo/branches/bar --repos=[URL|WC]
>> >> > 
>> >> > But that's much harder to type.
>> >
>> > Yup. :-) But not if you configure it somewhere so you don't have to type
>> > it.
>> 
>> So your solution is I should define an alias that allows me to type
>> 'svndiff ^/foo ^/bar wc' to run 'svn diff ^/foo ^/bar --repos=wc'.
>
> I didn't say that.

Then I'm not sure what you did mean.

>> I'd prefer to fix the client.
>> 
>> >>   Also the new syntax is consistent
>> >> > with most of the other commands that use '.' as a default, if one
>> >> > doesn't want to use '.' one specifies the path explicitly:
>> >
>> > No, hardly any commands take a WC argument which they only use to
>> > identify the repository. They nearly all focus their behaviour onto the
>> > particular path you specify.
>> 
>> Off the top of my head:
>> 
>> $ svn log -rNNN
>> $ svn list ^/branches
>> $ svn diff -cNNN
>> 
>> all will fail if wc is not a working copy and all will succeed if I
>> add a wc path.
>
> Sure, but they will produce output that relates to the WC path you
> specify, not just use it to find a repository and ignore it otherwise.

Perhaps. However

$ svn list ^/subversion/branches ../src/COMMITTERS

appears to use it just find a repository, and

$ svn merge ^/foo ^/bar wc

behaves in almost exactly the way I would like diff to behave.  I
agree it does use the wc path beyond merely constructing URLs, but the
way it constructs URLs is the way I would like diff to behave.

>> Comparing two branches in a repository is not an obscure operation.
>> We should make it easy to invoke.
>
> Sure. I agree.
>
> Can you come on IRC #svn-dev where we can discuss more easily? (Actually
> I must go get some lunch and put dinner in the oven now, but in an hour
> or so?)

OK.

-- 
Philip

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2426707

Please start new threads on the <[email protected]> mailing list.
To subscribe to the new list, send an empty e-mail to <[email protected]>.